zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AMReX: SYCL support (#31233)

Browse Source 
Add SYCL support, check CUDA-HIP-SYCL mutually exclusive. Require
AMReX ver 21.06+ for SYCL.

Co-authored-by: etpalmer63 <etpalmer63@users.noreply.github.com>
This commit is contained in:
Erik 2022-08-03 11:54:09 -04:00 committed by GitHub
parent af0e20ba9f
commit d93c074491
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
var/spack/repos/builtin/packages/amrex/package.py
View File

@ -3,6 +3,8 @@
# #
# SPDX-License-Identifier: (Apache-2.0 OR MIT) # SPDX-License-Identifier: (Apache-2.0 OR MIT)
import os
from spack.package import * from spack.package import *
@ -83,6 +85,7 @@ class Amrex(CMakePackage, CudaPackage, ROCmPackage):
variant("petsc", default=False, description="Enable PETSc interfaces") variant("petsc", default=False, description="Enable PETSc interfaces")
variant("sundials", default=False, description="Enable SUNDIALS interfaces") variant("sundials", default=False, description="Enable SUNDIALS interfaces")
variant("pic", default=False, description="Enable PIC") variant("pic", default=False, description="Enable PIC")
variant("sycl", default=False, description="Enable SYCL backend")
# Build dependencies # Build dependencies
depends_on("mpi", when="+mpi") depends_on("mpi", when="+mpi")
@ -125,6 +128,8 @@ class Amrex(CMakePackage, CudaPackage, ROCmPackage):
depends_on("hypre@2.19.0:", type="link", when="@21.03: ~cuda +hypre") depends_on("hypre@2.19.0:", type="link", when="@21.03: ~cuda +hypre")
depends_on("hypre@2.20.0:", type="link", when="@21.03: +cuda +hypre") depends_on("hypre@2.20.0:", type="link", when="@21.03: +cuda +hypre")
depends_on("petsc", type="link", when="+petsc") depends_on("petsc", type="link", when="+petsc")
depends_on("cmake@3.22:", type="build", when="+sycl")
depends_on("intel-oneapi-mkl", type=("build", "link"), when="+sycl")
# these versions of gcc have lambda function issues # these versions of gcc have lambda function issues
# see https://github.com/spack/spack/issues/22310 # see https://github.com/spack/spack/issues/22310
@ -184,7 +189,14 @@ class Amrex(CMakePackage, CudaPackage, ROCmPackage):
when="+rocm", when="+rocm",
msg="AMReX does not support rocm-4.2 due to a compiler bug", msg="AMReX does not support rocm-4.2 due to a compiler bug",
) )
# GPU vendor support is mutually exclusive
conflicts("+cuda", when="+rocm", msg="CUDA and HIP support are exclusive") conflicts("+cuda", when="+rocm", msg="CUDA and HIP support are exclusive")
conflicts("+cuda", when="+sycl", msg="CUDA and SYCL support are exclusive")
conflicts("+rocm", when="+sycl", msg="HIP and SYCL support are exclusive")
conflicts(
"+sycl", when="@:21.05", msg="For SYCL support, AMReX version 21.06 and newer suggested."
)
def url_for_version(self, version): def url_for_version(self, version):
if version >= Version("20.05"): if version >= Version("20.05"):
@ -244,6 +256,16 @@ def cmake_args(self):
targets = self.spec.variants["amdgpu_target"].value targets = self.spec.variants["amdgpu_target"].value
args.append("-DAMReX_AMD_ARCH=" + ";".join(str(x) for x in targets)) args.append("-DAMReX_AMD_ARCH=" + ";".join(str(x) for x in targets))
if "+sycl" in self.spec:
args.append("-DAMReX_GPU_BACKEND=SYCL")
# SYCL GPU backend only supported with Intel's oneAPI or DPC++ compilers
sycl_compatible_compilers = ["dpcpp", "icpx"]
if not (os.path.basename(self.compiler.cxx) in sycl_compatible_compilers):
raise InstallError(
"AMReX's SYCL GPU Backend requires DPC++ (dpcpp)"
+ " or the oneAPI CXX (icpx) compiler."
)
return args return args
# #