zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

root: fix setup_dependent_build_environment regression (#32115)

Browse Source 
`setup_dependent_build_environment(self, env, dependent_spec)` does not have a variable `spec`.

This causes several issues right now:
```console
==> Installing gaudi-36.6-cjjrpjwpcqrtojyrdqml3jpzkbn55hpb
==> No binary for gaudi-36.6-cjjrpjwpcqrtojyrdqml3jpzkbn55hpb found: installing from source
==> Error: NameError: name 'spec' is not defined

/home/wdconinc/git/spack/var/spack/repos/builtin/packages/root/package.py:614, in setup_dependent_build_environment:
        611        env.prepend_path("ROOT_INCLUDE_PATH", dependent_spec.prefix.include)
        612        if "+rpath" not in self.spec:
        613            env.prepend_path("LD_LIBRARY_PATH", self.prefix.lib.root)
  >>    614        if "platform=darwin" in spec:
        615            # Newer deployment targets cause fatal errors in rootcling
        616            env.unset("MACOSX_DEPLOYMENT_TARGET")
```
This commit is contained in:
Wouter Deconinck 2022-08-14 06:19:09 -05:00 committed by GitHub
parent b32cb5765c
commit e250371ee2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
var/spack/repos/builtin/packages/root/package.py
View File

@ -611,7 +611,7 @@ def setup_dependent_build_environment(self, env, dependent_spec):
env.prepend_path("ROOT_INCLUDE_PATH", dependent_spec.prefix.include) env.prepend_path("ROOT_INCLUDE_PATH", dependent_spec.prefix.include)
if "+rpath" not in self.spec: if "+rpath" not in self.spec:
env.prepend_path("LD_LIBRARY_PATH", self.prefix.lib.root) env.prepend_path("LD_LIBRARY_PATH", self.prefix.lib.root)
if "platform=darwin" in spec: if "platform=darwin" in self.spec:
# Newer deployment targets cause fatal errors in rootcling # Newer deployment targets cause fatal errors in rootcling
env.unset("MACOSX_DEPLOYMENT_TARGET") env.unset("MACOSX_DEPLOYMENT_TARGET")