zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Config option to disable setting S_ISGID bit when creating installation directory (#14479)

Browse Source 
* Add config option to disable setting S_ISGID bit when creating installation directory. 

Co-authored-by: Ivan Razumov <ivan.razumov@cern.ch>
This commit is contained in:
iarspider 2020-05-08 02:21:53 +02:00 committed by GitHub
parent 08f449ae9a
commit e2d42672b7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
etc/spack/defaults/config.yaml
View File

@ -157,3 +157,7 @@ config:
# Has no effect on macOS. DO NOT MIX these within the same install tree. # Has no effect on macOS. DO NOT MIX these within the same install tree.
# See the Spack documentation for details. # See the Spack documentation for details.
shared_linking: 'rpath' shared_linking: 'rpath'
# Set to 'false' to allow installation on filesystems that doesn't allow setgid bit
# manipulation by unprivileged user (e.g. AFS)
config:allow_sgid: true

2
lib/spack/spack/package_prefs.py
View File

@ -204,7 +204,7 @@ def get_package_dir_permissions(spec):
attribute sticky for the directory. Package-specific settings take attribute sticky for the directory. Package-specific settings take
precedent over settings for ``all``""" precedent over settings for ``all``"""
perms = get_package_permissions(spec) perms = get_package_permissions(spec)
if perms & stat.S_IRWXG: if perms & stat.S_IRWXG and spack.config.get('config:allow_sgid', True):
perms |= stat.S_ISGID perms |= stat.S_ISGID
return perms return perms

1
lib/spack/spack/schema/config.py
View File

@ -73,6 +73,7 @@
{'type': 'null'} {'type': 'null'}
], ],
}, },
'allow_sgid': {'type': 'boolean'},
}, },
}, },
} }