zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make it possible to build git without man pages and native language support (#23066)

Browse Source
This commit is contained in:
Harmen Stoppels 2021-04-27 22:47:59 +02:00 committed by GitHub
parent 99a5bf7892
commit e501f79d43
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
var/spack/repos/builtin/packages/git/package.py
View File

@ -212,7 +212,7 @@ class Git(AutotoolsPackage):
release['version']), release['version']),
sha256=release['sha256_manpages'], sha256=release['sha256_manpages'],
placement='git-manpages', placement='git-manpages',
when='@{0}'.format(release['version'])) when='@{0} +man'.format(release['version']))
variant('tcltk', default=False, variant('tcltk', default=False,
description='Gitk: provide Tcl/Tk in the run environment') description='Gitk: provide Tcl/Tk in the run environment')
@ -220,10 +220,14 @@ class Git(AutotoolsPackage):
description='Provide SVN Perl dependency in run environment') description='Provide SVN Perl dependency in run environment')
variant('perl', default=True, variant('perl', default=True,
description='Do not use Perl scripts or libraries at all') description='Do not use Perl scripts or libraries at all')
variant('nls', default=True,
description='Enable native language support')
variant('man', default=True,
description='Install manual pages')
depends_on('curl') depends_on('curl')
depends_on('expat') depends_on('expat')
depends_on('gettext') depends_on('gettext', when='+nls')
depends_on('iconv') depends_on('iconv')
depends_on('libidn2') depends_on('libidn2')
depends_on('openssl') depends_on('openssl')
@ -276,7 +280,7 @@ def setup_build_environment(self, env):
# The test avoids failures when git is an external package. # The test avoids failures when git is an external package.
# In that case the node in the DAG gets truncated and git DOES NOT # In that case the node in the DAG gets truncated and git DOES NOT
# have a gettext dependency. # have a gettext dependency.
if 'gettext' in self.spec: if '+nls' in self.spec:
if 'intl' in self.spec['gettext'].libs.names: if 'intl' in self.spec['gettext'].libs.names:
env.append_flags('EXTLIBS', '-L{0} -lintl'.format( env.append_flags('EXTLIBS', '-L{0} -lintl'.format(
self.spec['gettext'].prefix.lib)) self.spec['gettext'].prefix.lib))
@ -323,12 +327,27 @@ def filter_rt(self):
def check(self): def check(self):
make('test') make('test')
def build(self, spec, prefix):
args = []
if '~nls' in self.spec:
args.append('NO_GETTEXT=1')
make(*args)
def install(self, spec, prefix):
args = ["install"]
if '~nls' in self.spec:
args.append('NO_GETTEXT=1')
make(*args)
@run_after('install') @run_after('install')
def install_completions(self): def install_completions(self):
install_tree('contrib/completion', self.prefix.share) install_tree('contrib/completion', self.prefix.share)
@run_after('install') @run_after('install')
def install_manpages(self): def install_manpages(self):
if '~man' in self.spec:
return
prefix = self.prefix prefix = self.prefix
with working_dir('git-manpages'): with working_dir('git-manpages'):