zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Performance boost: reduce instantiations of re.Scanner

Browse Source 
- Lexer is the same for every Spec parser in spack, so don't build it
  every time.

- This improves time to import package.py files a lot, as a Lexer
  doesn't have to be constructed for every spc in the packages.

- To concretize dealii:
  - Before: ~20 sec
  - After:  ~6 sec
This commit is contained in:
Todd Gamblin 2016-05-28 22:01:58 -07:00
parent 6dcdb50a3e
commit e8b4d5fb6f
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/spack/spack/spec.py
View File

@ -2015,10 +2015,13 @@ def __init__(self):
(r'\s+', lambda scanner, val: None)]) (r'\s+', lambda scanner, val: None)])
# Lexer is always the same for every parser.
_lexer = SpecLexer()
class SpecParser(spack.parse.Parser): class SpecParser(spack.parse.Parser):
def __init__(self): def __init__(self):
super(SpecParser, self).__init__(SpecLexer()) super(SpecParser, self).__init__(_lexer)
self.previous = None self.previous = None
def do_parse(self): def do_parse(self):