zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bugfix: uninstall should find concrete specs by DAG hash

Browse Source 
This fixes a regression introduced in #10792.  `spack uninstall` in an
environment would not match concrete query specs properly after the index
hash of enviroments changed.

- [x] Search by DAG hash for specs to remove instead of by build hash
This commit is contained in:
Todd Gamblin 2019-11-05 02:37:49 -07:00
parent fbb5cf944b
commit ecfe84def7
No known key found for this signature in database
GPG Key ID: 66B24B9050FDD0B8
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/spack/spack/environment.py
View File

@ -833,8 +833,16 @@ def remove(self, query_spec, list_name=user_speclist_name, force=False):
if not matches: if not matches:
# concrete specs match against concrete specs in the env # concrete specs match against concrete specs in the env
# by *dag hash*, not build hash.
dag_hashes_in_order = [
self.specs_by_hash[build_hash].dag_hash()
for build_hash in self.concretized_order
]
specs_hashes = zip( specs_hashes = zip(
self.concretized_user_specs, self.concretized_order) self.concretized_user_specs, dag_hashes_in_order
)
matches = [ matches = [
s for s, h in specs_hashes s for s, h in specs_hashes
if query_spec.dag_hash() == h if query_spec.dag_hash() == h