zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spack create: fix for no URL (#31239)

Browse Source
This commit is contained in:
Adam J. Stewart
2022-06-22 11:45:03 -07:00
committed by GitHub
parent 5e9a8d27f7
commit ef278c601c
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/spack/spack/cmd/create.py
View File

@@ -826,7 +826,7 @@ def get_versions(args, name):
spack.util.url.require_url_format(args.url) spack.util.url.require_url_format(args.url)
if args.url.startswith('file://'): if args.url.startswith('file://'):
valid_url = False # No point in spidering these valid_url = False # No point in spidering these
except ValueError: except (ValueError, TypeError):
valid_url = False valid_url = False
if args.url is not None and args.template != 'bundle' and valid_url: if args.url is not None and args.template != 'bundle' and valid_url:

6
lib/spack/spack/test/cmd/create.py
View File

@@ -160,3 +160,9 @@ def _parse_name_offset(path, v):
spack.cmd.create.get_name(args) spack.cmd.create.get_name(args)
captured = capsys.readouterr() captured = capsys.readouterr()
assert "Couldn't guess a name" in str(captured) assert "Couldn't guess a name" in str(captured)
def test_no_url(parser):
"""Test creation of package without a URL."""
args = parser.parse_args(['--skip-editor', '-n', 'create-new-package'])
spack.cmd.create.create(parser, args)