diff --git a/lib/spack/spack/bootstrap/clingo.py b/lib/spack/spack/bootstrap/clingo.py index fb0150f49d4..d594b021b40 100644 --- a/lib/spack/spack/bootstrap/clingo.py +++ b/lib/spack/spack/bootstrap/clingo.py @@ -146,6 +146,7 @@ def libc_external_spec(self) -> "spack.spec.Spec": return self._external_spec(result) def _external_spec(self, initial_spec) -> "spack.spec.Spec": + #TODO: Does this need to be changed? initial_spec.namespace = "builtin" initial_spec.compiler = self.host_compiler.spec initial_spec.architecture = self.host_architecture diff --git a/lib/spack/spack/package_base.py b/lib/spack/spack/package_base.py index cce0bddfd7f..2454d1fc065 100644 --- a/lib/spack/spack/package_base.py +++ b/lib/spack/spack/package_base.py @@ -958,6 +958,7 @@ def fullnames(cls): namespace = getattr(cls, "namespace", None) if namespace: fullnames.append("%s.%s" % (namespace, cls.name)) + #TODO: Does this need to be changed? if namespace == "builtin": # builtin packages cannot inherit from other repos break diff --git a/lib/spack/spack/paths.py b/lib/spack/spack/paths.py index 84583cd552f..01668dd954e 100644 --- a/lib/spack/spack/paths.py +++ b/lib/spack/spack/paths.py @@ -58,7 +58,10 @@ # read-only things in $spack/var/spack repos_path = os.path.join(var_path, "repos") + +#TODO: How do we want to replace this? packages_path = os.path.join(repos_path, "builtin") + mock_packages_path = os.path.join(repos_path, "builtin.mock") # diff --git a/lib/spack/spack/repo.py b/lib/spack/spack/repo.py index 520c3f58b98..45b074b4648 100644 --- a/lib/spack/spack/repo.py +++ b/lib/spack/spack/repo.py @@ -57,7 +57,7 @@ def python_package_for_repo(namespace): For instance: - python_package_for_repo('builtin') == 'spack.pkg.builtin' + python_package_for_repo('builtin.mock') == 'spack.pkg.builtin.mock' Args: namespace (str): repo namespace @@ -70,7 +70,7 @@ def namespace_from_fullname(fullname): For instance: - namespace_from_fullname('spack.pkg.builtin.hdf5') == 'builtin' + namespace_from_fullname('spack.pkg.builtin.mock.hdf5') == 'builtin.mock' Args: fullname (str): full name for the Python module @@ -183,7 +183,10 @@ def packages_path(): try: return PATH.get_repo("builtin.mock").packages_path except UnknownNamespaceError: - return PATH.get_repo("builtin").packages_path + #TODO: Replace this with the approach needed to ensure using the new + #TODO: built-in repository option + #return PATH.get_repo("builtin").packages_path + return None class GitExe: diff --git a/lib/spack/spack/spec.py b/lib/spack/spack/spec.py index 14614969c72..4177ffc230d 100644 --- a/lib/spack/spack/spec.py +++ b/lib/spack/spack/spec.py @@ -2266,6 +2266,7 @@ def to_node_dict(self, hash=ht.dag_hash): ) return d + #TODO: Does the example namespace need to change from builtin? def to_dict(self, hash=ht.dag_hash): """Create a dictionary suitable for writing this spec to YAML or JSON.