zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Raise exception when 1+ stand-alone tests fail (#25857)

Browse Source
This commit is contained in:
Tamara Dahlgren 2021-09-15 05:04:59 -07:00 committed by GitHub
parent 75497537a4
commit f0b4afe7db
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/spack/spack/install_test.py
View File

@ -87,6 +87,8 @@ def __init__(self, specs, alias=None):
self.alias = alias self.alias = alias
self._hash = None self._hash = None
self.fails = 0
@property @property
def name(self): def name(self):
return self.alias if self.alias else self.content_hash return self.alias if self.alias else self.content_hash
@ -135,6 +137,7 @@ def __call__(self, *args, **kwargs):
shutil.rmtree(test_dir) shutil.rmtree(test_dir)
self.write_test_result(spec, 'PASSED') self.write_test_result(spec, 'PASSED')
except BaseException as exc: except BaseException as exc:
self.fails += 1
if isinstance(exc, SyntaxError): if isinstance(exc, SyntaxError):
# Create the test log file and report the error. # Create the test log file and report the error.
self.ensure_stage() self.ensure_stage()
@ -150,6 +153,9 @@ def __call__(self, *args, **kwargs):
self.current_test_spec = None self.current_test_spec = None
self.current_base_spec = None self.current_base_spec = None
if self.fails:
raise TestSuiteFailure(self.fails)
def ensure_stage(self): def ensure_stage(self):
if not os.path.exists(self.stage): if not os.path.exists(self.stage):
fs.mkdirp(self.stage) fs.mkdirp(self.stage)
@ -269,3 +275,11 @@ def __init__(self, failures):
msg += '\n%s\n' % message msg += '\n%s\n' % message
super(TestFailure, self).__init__(msg) super(TestFailure, self).__init__(msg)
class TestSuiteFailure(spack.error.SpackError):
"""Raised when one or more tests in a suite have failed."""
def __init__(self, num_failures):
msg = "%d test(s) in the suite failed.\n" % num_failures
super(TestSuiteFailure, self).__init__(msg)