package : split environment_modifications into setup_environment and setup_dependent_environment.

package : renamed `module_modifications` to `modify_module` for consistency

var/spack/repos/builtin/packages/ruby/package.py

@@ -17,8 +17,7 @@ def install(self, spec, prefix):
         make()
         make("install")
 
-    def environment_modifications(self, extension_spec):
-        env = super(Ruby, self).environment_modifications(extension_spec)
+    def setup_dependent_environment(self, env, extension_spec):
         # Set GEM_PATH to include dependent gem directories
         ruby_paths = []
         for d in extension_spec.traverse():
@@ -27,9 +26,8 @@ def environment_modifications(self, extension_spec):
         env.set_env('GEM_PATH', concatenate_paths(ruby_paths))
         # The actual installation path for this gem
         env.set_env('GEM_HOME', extension_spec.prefix)
-        return env
 
-    def module_modifications(self, module, spec, ext_spec):
+    def modify_module(self, module, spec, ext_spec):
         """Called before ruby modules' install() methods.  Sets GEM_HOME
         and GEM_PATH to values appropriate for the package being built.