zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/cmd/maintainers.py: cleanup of mock_packages use (#50334)

Browse Source
This commit is contained in:
Tamara Dahlgren 2025-05-07 00:03:00 -07:00 committed by GitHub
parent f151bc65f7
commit f485a622c8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/spack/spack/test/cmd/maintainers.py
View File

@ -9,6 +9,8 @@
import spack.main import spack.main
import spack.repo import spack.repo
pytestmark = [pytest.mark.usefixtures("mock_packages")]
maintainers = spack.main.SpackCommand("maintainers") maintainers = spack.main.SpackCommand("maintainers")
MAINTAINED_PACKAGES = [ MAINTAINED_PACKAGES = [
@ -26,17 +28,17 @@ def split(output):
return re.split(r"\s+", output) if output else [] return re.split(r"\s+", output) if output else []
def test_maintained(mock_packages): def test_maintained():
out = split(maintainers("--maintained")) out = split(maintainers("--maintained"))
assert out == MAINTAINED_PACKAGES assert out == MAINTAINED_PACKAGES
def test_unmaintained(mock_packages): def test_unmaintained():
out = split(maintainers("--unmaintained")) out = split(maintainers("--unmaintained"))
assert out == sorted(set(spack.repo.all_package_names()) - set(MAINTAINED_PACKAGES)) assert out == sorted(set(spack.repo.all_package_names()) - set(MAINTAINED_PACKAGES))
def test_all(mock_packages, capfd): def test_all(capfd):
with capfd.disabled(): with capfd.disabled():
out = split(maintainers("--all")) out = split(maintainers("--all"))
assert out == [ assert out == [
@ -63,7 +65,7 @@ def test_all(mock_packages, capfd):
assert out == ["maintainers-1:", "user1,", "user2"] assert out == ["maintainers-1:", "user1,", "user2"]
def test_all_by_user(mock_packages, capfd): def test_all_by_user(capfd):
with capfd.disabled(): with capfd.disabled():
out = split(maintainers("--all", "--by-user")) out = split(maintainers("--all", "--by-user"))
assert out == [ assert out == [
@ -100,22 +102,22 @@ def test_all_by_user(mock_packages, capfd):
] ]
def test_no_args(mock_packages): def test_no_args():
with pytest.raises(spack.main.SpackCommandError): with pytest.raises(spack.main.SpackCommandError):
maintainers() maintainers()
def test_no_args_by_user(mock_packages): def test_no_args_by_user():
with pytest.raises(spack.main.SpackCommandError): with pytest.raises(spack.main.SpackCommandError):
maintainers("--by-user") maintainers("--by-user")
def test_mutex_args_fail(mock_packages): def test_mutex_args_fail():
with pytest.raises(SystemExit): with pytest.raises(SystemExit):
maintainers("--maintained", "--unmaintained") maintainers("--maintained", "--unmaintained")
def test_maintainers_list_packages(mock_packages, capfd): def test_maintainers_list_packages(capfd):
with capfd.disabled(): with capfd.disabled():
out = split(maintainers("maintainers-1")) out = split(maintainers("maintainers-1"))
assert out == ["user1", "user2"] assert out == ["user1", "user2"]
@ -129,13 +131,13 @@ def test_maintainers_list_packages(mock_packages, capfd):
assert out == ["user2", "user3"] assert out == ["user2", "user3"]
def test_maintainers_list_fails(mock_packages, capfd): def test_maintainers_list_fails(capfd):
out = maintainers("pkg-a", fail_on_error=False) out = maintainers("pkg-a", fail_on_error=False)
assert not out assert not out
assert maintainers.returncode == 1 assert maintainers.returncode == 1
def test_maintainers_list_by_user(mock_packages, capfd): def test_maintainers_list_by_user(capfd):
with capfd.disabled(): with capfd.disabled():
out = split(maintainers("--by-user", "user1")) out = split(maintainers("--by-user", "user1"))
assert out == ["maintainers-1", "maintainers-3", "py-extension1"] assert out == ["maintainers-1", "maintainers-3", "py-extension1"]