From f49fa74bf7a1b28b317f9dce86a24b1b7deb9ea6 Mon Sep 17 00:00:00 2001
From: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
Date: Wed, 5 Aug 2020 16:29:53 -0700
Subject: [PATCH] Smoke test: Add test of a sequence of hdf5 commands (#17686)

---
 .../repos/builtin/packages/hdf5/package.py    |  27 +++++++++++
 .../repos/builtin/packages/hdf5/test/dump.out |  45 ++++++++++++++++++
 .../repos/builtin/packages/hdf5/test/spack.h5 | Bin 0 -> 8928 bytes
 3 files changed, 72 insertions(+)
 create mode 100644 var/spack/repos/builtin/packages/hdf5/test/dump.out
 create mode 100644 var/spack/repos/builtin/packages/hdf5/test/spack.h5

diff --git a/var/spack/repos/builtin/packages/hdf5/package.py b/var/spack/repos/builtin/packages/hdf5/package.py
index e7134032352..a6bc4543fbb 100644
--- a/var/spack/repos/builtin/packages/hdf5/package.py
+++ b/var/spack/repos/builtin/packages/hdf5/package.py
@@ -3,9 +3,11 @@
 #
 # SPDX-License-Identifier: (Apache-2.0 OR MIT)
 
+import os
 import shutil
 import sys
 
+import llnl.util.tty as tty
 from spack import *
 
 
@@ -391,10 +393,35 @@ def _test_check_versions(self):
             self.run_test(exe, [option], spec_vers_str, None, installed=True,
                           purpose=reason, skip_missing=True)
 
+    def _test_example(self):
+        """This test performs copy, dump, and diff on an example hdf5 file."""
+        h5_file = os.path.join(self.test_dir, 'data', 'spack.h5')
+
+        reason = 'test: ensure h5dump produces expected output'
+        dump_file = os.path.join(self.test_dir, 'data', 'dump.out')
+        output = ''
+        with open(dump_file) as fd:
+            output == fd.read()
+        self.run_test('h5dump', [h5_file], output, None, installed=True,
+                      purpose=reason, skip_missing=True, work_dir='.')
+
+        reason = 'test: ensure h5copy runs'
+        options = ['-i', h5_file, '-s', 'Spack', '-o', 'test.h5', '-d', 'Spack']
+        self.run_test('h5copy', options, '', None, installed=True,
+                      purpose=reason, skip_missing=True, work_dir='.')
+
+        reason = 'test: ensure h5diff shows no differences in orig and copy'
+        options = [h5_file, 'test.h5']
+        self.run_test('h5diff', options, '', None, installed=True,
+                      purpose=reason, skip_missing=True, work_dir='.')
+
     def test(self):
         """Perform smoke tests on the installed package."""
         # Simple version check tests on known binaries
         self._test_check_versions()
 
+        # Run sequence of commands on an hdf5 file
+        self._test_example()
+
         # Run existing install check
         self.check_install()
diff --git a/var/spack/repos/builtin/packages/hdf5/test/dump.out b/var/spack/repos/builtin/packages/hdf5/test/dump.out
new file mode 100644
index 00000000000..58decefc127
--- /dev/null
+++ b/var/spack/repos/builtin/packages/hdf5/test/dump.out
@@ -0,0 +1,45 @@
+HDF5 "spack.h5" {
+GROUP "/" {
+   GROUP "Spack" {
+      GROUP "Software" {
+         ATTRIBUTE "Distribution" {
+            DATATYPE  H5T_STRING {
+               STRSIZE H5T_VARIABLE;
+               STRPAD H5T_STR_NULLTERM;
+               CSET H5T_CSET_UTF8;
+               CTYPE H5T_C_S1;
+            }
+            DATASPACE  SCALAR
+            DATA {
+            (0): "Open Source"
+            }
+         }
+         DATASET "data" {
+            DATATYPE  H5T_IEEE_F64LE
+            DATASPACE  SIMPLE { ( 7, 11 ) / ( 7, 11 ) }
+            DATA {
+            (0,0): 0.371141, 0.508482, 0.585975, 0.0944911, 0.684849,
+            (0,5): 0.580396, 0.720271, 0.693561, 0.340432, 0.217145,
+            (0,10): 0.636083,
+            (1,0): 0.686996, 0.773501, 0.656767, 0.617543, 0.226132,
+            (1,5): 0.768632, 0.0548711, 0.54572, 0.355544, 0.591548,
+            (1,10): 0.233007,
+            (2,0): 0.230032, 0.192087, 0.293845, 0.0369338, 0.038727,
+            (2,5): 0.0977931, 0.966522, 0.0821391, 0.857921, 0.495703,
+            (2,10): 0.746006,
+            (3,0): 0.598494, 0.990266, 0.993009, 0.187481, 0.746391,
+            (3,5): 0.140095, 0.122661, 0.929242, 0.542415, 0.802758,
+            (3,10): 0.757941,
+            (4,0): 0.372124, 0.411982, 0.270479, 0.950033, 0.329948,
+            (4,5): 0.936704, 0.105097, 0.742285, 0.556565, 0.18988, 0.72797,
+            (5,0): 0.801669, 0.271807, 0.910649, 0.186251, 0.868865,
+            (5,5): 0.191484, 0.788371, 0.920173, 0.582249, 0.682022,
+            (5,10): 0.146883,
+            (6,0): 0.826824, 0.0886705, 0.402606, 0.0532444, 0.72509,
+            (6,5): 0.964683, 0.330362, 0.833284, 0.630456, 0.411489, 0.247806
+            }
+         }
+      }
+   }
+}
+}
diff --git a/var/spack/repos/builtin/packages/hdf5/test/spack.h5 b/var/spack/repos/builtin/packages/hdf5/test/spack.h5
new file mode 100644
index 0000000000000000000000000000000000000000..c2f3a6f39dae2d630a2cee4d3c3ecfa5058b2408
GIT binary patch
literal 8928
zcmeI1eN0nV6u@r_O&<yZZcf^0s6xy#bi)icg2V#@v>Pf+L<zb{K^Tk(SX%6&Y{tb2
zPKB}HAe)*_T|2u(Bh!EbSJCjX!uXIcn<-F%mTC*zV#tJy_4VDm%qENC{@KR8FL~$Q
zbI&>N-QPR!{&8-xG<vPq9Pu2)Hikj&$j8|ww`tr4mU0?0Ci5w{!^5%&OD&)4@DO_;
z<cIaXIKHdh=1nm%$YDw16N%lBWD(b6h=R&lML-%88P6^_39p)DX%o&f0wW<$mX_@p
zkbIPqiKmp0%ga777ntVdQv&{vySe5i+2>LOk1i}BH$$;UCQm0?lAjSoF+=%x`>Mo^
z3lxE$|G4}u6>;`7e`ojs{wL<H`AhayiAzH4lqqEFl1bkF(|vVaRNQ)JEc`$ccP{1{
zmzSO+Nyt^o)BgNroHOm-*nkR3fD)htC;>`<5}*Vq0ZM=ppaduZN`Mmh*Aw6&zO$B)
ziQkl*3k;CD8LmHgBB|p{f~`Avp=S|;qO<Z9@~l*)A}cqCbrtb=&JzW;jKI|pILE)%
z6I3`BtK%Vo)2@_tb~GM(o|AmeL+BhKMCuT(V>ic125adn0ms|0EdqtiMIqC;?j~?(
z*?B&n3&`M;4>z7l!dfGg`AEfjK90irYz`OiNZ1$`&DQqtE2D8zP;~mz+mjM-<*33O
zxvz|nYo0x6+}UR5%CQ>%pM;}py?M6rq3fjtD1n(1xWDjd=nZ`@9J+t1bzjT?>^{D|
zBu;Mvm41b>G`Jd8Z^;^xT8BZbllE4YnP5s|eMaeN248=^muBS%G<4fi&Ng?0>V<;$
z-ZdEDrOxw(KO_%<xa)ewoylSFIFnI!P;Y_$q*p##?LG_-tPkbZ`n#Y~ugM?zxdnnN
znPsOdERd&}820x22I?cVZyzog1fM#KXV|qK@E8+|AJ|Nwm554$Z?;0Hx=em?cPo5r
zkWIgNya|&046i5u*a`7{x%;OqUjh;;j|jU?1Jf~KnP6(*{pS7Jt2R4?)`su$6<z{C
z-E*53D(*pQ@`tIP)%3%@H4%HI{bsQKIudky*<FbB-!6)}Fa}>-sW1PoVGP{M7yIv+
zZiK`}ZCj4X45;B!wAy|R#(O?)ug>@$HrAaznOtiFjm~4VVA~)RmX0e|UKoXvRka7_
zMOvVzCA?~|y%+R~THWYdMi8F}eX%I61DF%3#kveT)C+csZ!hkK1;HWtdw;Wmq|&HW
zo3B6`T3X$rH-qkzVxg>U5aN&4*?-^A1OX!3@<Xv^n5wBV#Arq#<MXX6r0E^dnHaW>
z3A90A`mUmRy^Rp$VS8BDdJldoclSAbpb45Q`ZjC{8-<>}S6jT~HrUgoy49#Q!Pf%?
zYb7^_Vc@IDCEl&|ko3kc>06anh+lPm{i3SNpj}`Lh`n(O#*efY8eh}Fsgv2s<1d@x
zQ>c-jzhejYmigz-1a`wald2_A=dAF-)nk`0E+2ve(?PPXL?dLb%MS3bZi7DnpHQ=C

literal 0
HcmV?d00001