Adding some fixes to packages that use configure_args function without setting spec set or directly referencing it (#2868)

* Adding 'self.' to the spec call for configure_args

* Updating this to set spec to self.spec

* More updates to the configure_args spec calls

* Another spec issue

* Another spec issue.

* And another spec issue

* Switching cmor back to self.spec.

var/spack/repos/builtin/packages/emacs/package.py

@@ -48,6 +48,7 @@ class Emacs(AutotoolsPackage):
     depends_on('gtkplus+X', when='+X toolkit=gtk')
 
     def configure_args(self):
+        spec = self.spec
         args = []
         toolkit = spec.variants['toolkit'].value
         if '+X' in spec:

var/spack/repos/builtin/packages/libcerf/package.py

@@ -38,6 +38,7 @@ class Libcerf(AutotoolsPackage):
     version('1.3', 'b3504c467204df71e62aeccf73a25612')
 
     def configure_args(self):
+        spec = self.spec
         options = []
         # Clang reports unused functions as errors, see
         # http://clang.debian.net/status.php?version=3.8.1&key=UNUSED_FUNCTION

var/spack/repos/builtin/packages/libevent/package.py

@@ -53,6 +53,7 @@ class Libevent(AutotoolsPackage):
     depends_on('openssl', when='+openssl')
 
     def configure_args(self):
+        spec = self.spec
         configure_args = []
         if '+openssl' in spec:
             configure_args.append('--enable-openssl')

var/spack/repos/builtin/packages/libxml2/package.py

@@ -46,6 +46,7 @@ class Libxml2(AutotoolsPackage):
     depends_on('pkg-config@0.9.0:', type='build')
 
     def configure_args(self):
+        spec = self.spec
         if '+python' in spec:
             python_args = [
                 '--with-python={0}'.format(spec['python'].prefix),