lrslib: fix return value (#14422)

var/spack/repos/builtin/packages/lrslib/fix-return-value.patch

@@ -0,0 +1,38 @@
+--- spack-src/lrsnashlib.c.org	2020-01-08 13:22:31.512928411 +0900
++++ spack-src/lrsnashlib.c	2020-01-08 13:24:51.047429971 +0900
+@@ -52,7 +52,7 @@
+ 
+   Q1 = lrs_alloc_dat("LRS globals");    /* allocate and init structure for static problem data */
+   if (Q1 == NULL) {
+-    return;
++    return 1;
+   }
+ 
+   Q1->nash = TRUE;
+@@ -64,7 +64,7 @@
+ 
+   P1 = lrs_alloc_dic(Q1);       /* allocate and initialize lrs_dic */
+   if (P1 == NULL) {
+-    return;
++    return 1;
+   }
+ 
+   BuildRep(P1, Q1, g, 1, 0);
+@@ -74,7 +74,7 @@
+   /* allocate and init structure for player 2's problem data */
+   Q2 = lrs_alloc_dat("LRS globals");
+   if (Q2 == NULL) {
+-    return;
++    return 1;
+   }
+ 
+   Q2->debug = Debug_flag;
+@@ -86,7 +86,7 @@
+ 
+   P2orig = lrs_alloc_dic(Q2);   /* allocate and initialize lrs_dic */
+   if (P2orig == NULL) {
+-    return;
++    return 1;
+   }
+   BuildRep(P2orig, Q2, g, 0, 1);
+   A2orig = P2orig->A;

var/spack/repos/builtin/packages/lrslib/package.py

@@ -27,6 +27,8 @@ class Lrslib(Package):
     depends_on("libtool", type="build")
 
     patch("Makefile.spack.patch")
+    # Ref: https://github.com/mkoeppe/lrslib/commit/2e8c5bd6c06430151faea5910f44aa032c4178a9
+    patch('fix-return-value.patch')
 
     def url_for_version(self, version):
         url = "http://cgm.cs.mcgill.ca/~avis/C/lrslib/archive/lrslib-0{0}.tar.gz"