Rename build.out to build.txt (#11749)

Rename build.out to build.txt; makes it easier when people post log files to the Spack mailing list.

lib/spack/spack/directory_layout.py

@@ -190,7 +190,7 @@ def __init__(self, root, **kwargs):
         self.metadata_dir        = '.spack'
         self.spec_file_name      = 'spec.yaml'
         self.extension_file_name = 'extensions.yaml'
-        self.build_log_name      = 'build.out'  # build log.
+        self.build_log_name      = 'build.txt'  # build log.
         self.build_env_name      = 'build.env'  # build environment
         self.packages_dir        = 'repos'      # archive of package.py files
 

lib/spack/spack/package.py

@@ -433,7 +433,7 @@ class PackageBase(with_metaclass(PackageMeta, PackageViewMixin, object)):
     #: List of glob expressions. Each expression must either be
     #: absolute or relative to the package source path.
     #: Matching artifacts found at the end of the build process will
-    #: be copied in the same directory tree as build.env and build.out.
+    #: be copied in the same directory tree as build.env and build.txt.
     archive_files = []
 
     #
@@ -786,7 +786,7 @@ def env_path(self):
 
     @property
     def log_path(self):
-        return os.path.join(self.stage.path, 'spack-build.out')
+        return os.path.join(self.stage.path, 'spack-build.txt')
 
     def _make_fetcher(self):
         # Construct a composite fetcher that always contains at least
@@ -1814,7 +1814,7 @@ def build_log_path(self):
         if self.installed:
             return spack.store.layout.build_log_path(self.spec)
         else:
-            return os.path.join(self.stage.path, 'spack-build.out')
+            return self.log_path
 
     @classmethod
     def inject_flags(cls, name, flags):

lib/spack/spack/test/cmd/install.py

@@ -125,7 +125,7 @@ def test_package_output(tmpdir, capsys, install_mockery, mock_fetch):
     pkg = spec.package
     pkg.do_install(verbose=True)
 
-    log_file = os.path.join(spec.prefix, '.spack', 'build.out')
+    log_file = os.path.join(spec.prefix, '.spack', 'build.txt')
     with open(log_file) as f:
         out = f.read()