zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

static_to_shared_library: separate options from option values (#9690)

Browse Source 
The 'static_to_shared_library' function takes a compiler Executable,
which is intended to be invoked with a list of arguments; the
arguments must be separated from their values in the list, given
the way that 'Executable.__call__' invokes the underlying executable.
'static_to_shared_library' was not doing this, which this commit fixes.
This commit is contained in:
Satish Balay
2018-10-31 14:49:04 -05:00
committed by Peter Scheibel
parent 939ce40032
commit fb849a4b7f
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/spack/spack/build_environment.py
View File

@@ -497,16 +497,16 @@ def _static_to_shared_library(arch, compiler, static_lib, shared_lib=None,
compiler_args = [
'-dynamiclib',
'-install_name {0}'.format(install_name),
'-install_name', '{0}'.format(install_name),
'-Wl,-force_load,{0}'.format(static_lib)
]
if compat_version:
compiler_args.append('-compatibility_version {0}'.format(
compat_version))
compiler_args.extend(['-compatibility_version', '{0}'.format(
compat_version)])
if version:
compiler_args.append('-current_version {0}'.format(version))
compiler_args.extend(['-current_version', '{0}'.format(version)])
if len(arguments) > 0:
compiler_args.extend(arguments)