From fc2793f98f0e177ef270f92bff39406d60362130 Mon Sep 17 00:00:00 2001 From: Massimiliano Culpo Date: Fri, 24 Jan 2025 14:57:26 +0100 Subject: [PATCH] Improve info messages --- lib/spack/spack/compilers/config.py | 9 ++++++--- lib/spack/spack/solver/asp.py | 5 ++++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/lib/spack/spack/compilers/config.py b/lib/spack/spack/compilers/config.py index 22e611e1438..6568cdded02 100644 --- a/lib/spack/spack/compilers/config.py +++ b/lib/spack/spack/compilers/config.py @@ -7,7 +7,6 @@ import os import re import sys -import warnings from typing import Any, Dict, List, Optional, Tuple import archspec.cpu @@ -137,7 +136,11 @@ def _init_packages_yaml( for legacy in legacy_compilers: by_name.setdefault(legacy.name, []).append(legacy) spack.detection.update_configuration(by_name, buildable=True, scope=scope) - warnings.warn("compilers have been automatically converted from existing 'compilers.yaml'") + tty.info( + "Compilers have been converted from 'compilers.yaml' and written to " + "'packages.yaml'. Use of 'compilers.yaml' is deprecated, and will be " + "ignored in future versions of Spack" + ) return # Look for compilers in PATH @@ -146,7 +149,7 @@ def _init_packages_yaml( raise NoAvailableCompilerError( "no compiler configured, and Spack cannot find working compilers in PATH" ) - warnings.warn("compilers have been configured automatically from PATH inspection") + tty.info("Compilers have been configured automatically from PATH inspection") def all_compilers_from( diff --git a/lib/spack/spack/solver/asp.py b/lib/spack/spack/solver/asp.py index 7274dd2c3e1..c6d8a515111 100644 --- a/lib/spack/spack/solver/asp.py +++ b/lib/spack/spack/solver/asp.py @@ -93,6 +93,7 @@ TransformFunction = Callable[[spack.spec.Spec, List[AspFunction]], List[AspFunction]] + class OutputConfiguration(NamedTuple): """Data class that contains configuration on what a clingo solve should output.""" @@ -3428,7 +3429,9 @@ def possible_compilers(*, configuration) -> List["spack.spec.Spec"]: continue if c in result: - warnings.warn(f"duplicate {c} compiler found. Edit your packages.yaml to remove it.") + warnings.warn( + f"duplicate {c.long_spec} compiler found. Edit your packages.yaml to remove it." + ) continue result.add(c)