zhangyiss/spack
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RCCL: only build tests when requested (#48387)

Browse Source
This commit is contained in:
Seth R. Johnson 2025-01-04 09:46:15 -05:00 committed by GitHub
parent 0576ef081a
commit fd51f1ce65
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
var/spack/repos/builtin/packages/rccl/package.py
View File

@ -111,7 +111,7 @@ class Rccl(CMakePackage):
]:
depends_on(f"rocm-core@{ver}", when=f"@{ver}")
depends_on("googletest@1.11.0:", when="@5.3:")
depends_on("googletest@1.11.0:", type="test", when="@5.3:")
@classmethod
def determine_version(cls, lib):
@ -138,10 +138,10 @@ def cmake_args(self):
args.append(self.define_from_variant("AMDGPU_TARGETS", "amdgpu_target"))
if self.spec.satisfies("^cmake@3.21.0:3.21.2"):
args.append(self.define("__skip_rocmclang", "ON"))
args.append(self.define("__skip_rocmclang", True))
if self.spec.satisfies("@5.3.0:"):
args.append(self.define("BUILD_TESTS", "ON"))
args.append(self.define("BUILD_TESTS", self.run_tests))
return args
def test_unit(self):