From fd51f1ce656358c15c633a5261769230b9cac03c Mon Sep 17 00:00:00 2001 From: "Seth R. Johnson" Date: Sat, 4 Jan 2025 09:46:15 -0500 Subject: [PATCH] RCCL: only build tests when requested (#48387) --- var/spack/repos/builtin/packages/rccl/package.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/var/spack/repos/builtin/packages/rccl/package.py b/var/spack/repos/builtin/packages/rccl/package.py index bdd150f1d88..6be20fc5961 100644 --- a/var/spack/repos/builtin/packages/rccl/package.py +++ b/var/spack/repos/builtin/packages/rccl/package.py @@ -111,7 +111,7 @@ class Rccl(CMakePackage): ]: depends_on(f"rocm-core@{ver}", when=f"@{ver}") - depends_on("googletest@1.11.0:", when="@5.3:") + depends_on("googletest@1.11.0:", type="test", when="@5.3:") @classmethod def determine_version(cls, lib): @@ -138,10 +138,10 @@ def cmake_args(self): args.append(self.define_from_variant("AMDGPU_TARGETS", "amdgpu_target")) if self.spec.satisfies("^cmake@3.21.0:3.21.2"): - args.append(self.define("__skip_rocmclang", "ON")) + args.append(self.define("__skip_rocmclang", True)) if self.spec.satisfies("@5.3.0:"): - args.append(self.define("BUILD_TESTS", "ON")) + args.append(self.define("BUILD_TESTS", self.run_tests)) return args def test_unit(self):