Massimiliano Culpo
288298bd2c
ci: don't run unit-test on ubuntu 20.04 ( #49826 )
...
Compatibility with Python 3.6 is still tested by the
rhel8-platform-python job, and Ubuntu 20.04 will be
removed soon from the list of runners:
https://github.com/actions/runner-images/issues/11101
Signed-off-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
2025-04-01 17:33:24 +02:00
dependabot[bot]
cf70d71ba8
build(deps): bump flake8 in /.github/workflows/requirements/style ( #49815 )
...
Bumps [flake8](https://github.com/pycqa/flake8 ) from 7.1.2 to 7.2.0.
- [Commits](https://github.com/pycqa/flake8/compare/7.1.2...7.2.0 )
---
updated-dependencies:
- dependency-name: flake8
dependency-version: 7.2.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-04-01 08:34:26 +02:00
John W. Parent
b87c025cd3
Remove spack sh setup ( #49747 )
2025-03-27 16:40:39 -07:00
Alec Scott
4ff43d7fa9
ci: future-proof for enabling GitHub merge queues later ( #49665 )
2025-03-25 10:07:37 -07:00
Alec Scott
c79b6207e8
ci: add automatic checksum verification check ( #45063 )
...
Add a CI check to automatically verify the checksums of newly added
package versions:
- [x] a new command, `spack ci verify-versions`
- [x] a GitHub actions check to run the command
- [x] tests for the new command
This also eliminates the suggestion for maintainers to manually verify added
checksums in the case of accidental version <--> checksum mismatches.
----
Signed-off-by: Todd Gamblin <tgamblin@llnl.gov>
2025-03-20 22:58:14 +01:00
dependabot[bot]
7674ea0b7d
build(deps): bump types-six in /.github/workflows/requirements/style ( #49295 )
...
Bumps [types-six](https://github.com/python/typeshed ) from 1.17.0.20241205 to 1.17.0.20250304.
- [Commits](https://github.com/python/typeshed/commits )
---
updated-dependencies:
- dependency-name: types-six
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-05 22:34:49 -06:00
dependabot[bot]
b42f0d793d
build(deps): bump isort in /.github/workflows/requirements/style ( #49212 )
...
Bumps [isort](https://github.com/PyCQA/isort ) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/PyCQA/isort/releases )
- [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md )
- [Commits](https://github.com/PyCQA/isort/compare/6.0.0...6.0.1 )
---
updated-dependencies:
- dependency-name: isort
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-01 08:18:06 -07:00
dependabot[bot]
2ffbc0d053
build(deps): bump mypy in /.github/workflows/requirements/style ( #49165 )
...
Bumps [mypy](https://github.com/python/mypy ) from 1.11.2 to 1.15.0.
- [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md )
- [Commits](https://github.com/python/mypy/compare/v1.11.2...v1.15.0 )
---
updated-dependencies:
- dependency-name: mypy
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-23 22:29:24 -06:00
dependabot[bot]
dae3b69f2c
build(deps): bump flake8 in /.github/workflows/requirements/style ( #49086 )
...
Bumps [flake8](https://github.com/pycqa/flake8 ) from 7.1.1 to 7.1.2.
- [Commits](https://github.com/pycqa/flake8/compare/7.1.1...7.1.2 )
---
updated-dependencies:
- dependency-name: flake8
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-17 18:13:42 -06:00
dependabot[bot]
aaaf4477c9
build(deps): bump black in /.github/workflows/requirements/style ( #48779 )
...
Bumps [black](https://github.com/psf/black ) from 24.10.0 to 25.1.0.
- [Release notes](https://github.com/psf/black/releases )
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md )
- [Commits](https://github.com/psf/black/compare/24.10.0...25.1.0 )
---
updated-dependencies:
- dependency-name: black
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-16 17:42:46 -07:00
dependabot[bot]
a472adf2cb
build(deps): bump isort in /.github/workflows/requirements/style ( #48746 )
...
Bumps [isort](https://github.com/pycqa/isort ) from 5.13.2 to 6.0.0.
- [Release notes](https://github.com/pycqa/isort/releases )
- [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md )
- [Commits](https://github.com/pycqa/isort/compare/5.13.2...6.0.0 )
---
updated-dependencies:
- dependency-name: isort
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-16 16:27:35 -07:00
Harmen Stoppels
5d8517ef69
import-check: bump ( #48968 )
2025-02-10 20:48:59 +01:00
Harmen Stoppels
9a2b0aca66
ci: bump import-check ( #48883 )
2025-02-05 09:17:01 +01:00
Todd Gamblin
89a8ab3233
ci: add codecov token secret to coverage upload job ( #48880 )
...
Codecov needs to see the token secret when uploading, so we have to
add this line to the workflow YAML:
```yaml
with:
token: ${{ secrets.CODECOV_TOKEN }}
```
Signed-off-by: Todd Gamblin <tgamblin@llnl.gov>
2025-02-05 01:18:02 +00:00
Harmen Stoppels
5d87166c07
gha: standalone import-check ( #48873 )
2025-02-04 22:18:30 +01:00
Harmen Stoppels
9642f3f49a
import-check: enable color output ( #48842 )
2025-02-03 11:02:21 +01:00
Harmen Stoppels
763b35a2e0
import-check: improve how problematic imports are displayed ( #48825 )
...
The import-check action now presents problematic import statements
introduced by the PR better.
The idea is roughly:
* Let (V₁, E₁) be the graph of modules as vertices and import statements
as edges before the change
* Let (V₂, E₂) be the graph after the code change, which is typically a small
perturbation of (V₁, E₁).
* X₁ = FAS(V₁, E₁) is the feedback arc set before (a minimal set of edges to
delete to make it acyclic)
* X₂ = FAS(V₂, E₂ ∖ X₁) is the feedback arc set after deletion of the minimal
set of edges that made the old graph acyclic.
* X₃ = FAS(V₂, E₂) is the feedback arc set after
Previously I displayed X₁ and X₃ and users had to diff themselves.
Now, I'm showing X₂, which is a small set, typically directly related to
code changes.
However, it can be that a small code change adding say 2 problematic imports
creates a completely different solution X₃ that only requires deletion of just 1
different import. In that case the user is informed that they can potentially do
less work.
So for PR #48784 the output is now:
> The overall number of problematic import statements increased by 1 from 31 to 32.
> This is likely a direct consequence of the following import statements:
>
> ```
> spack/config imports: spack.spec, spack.util.path, spack.util.remote_file_cache
> ```
>
> However, instead of removing 3 import statements, it is sufficient to remove only 1
> import statement from the following list:
>
> ```
> spack/concretize imports: spack.bootstrap, spack.solver.asp
> spack/environment imports: spack.bootstrap, spack.environment
> spack/fetch_strategy imports: spack.version.git_ref_lookup
> spack/install_test imports: spack.build_environment, spack.package_base
> spack/modules imports: spack.modules
> spack/platforms imports: spack.config
> spack/relocate imports: spack.bootstrap
> spack/repo imports: spack.package_base, spack.patch, spack.tag
> spack/spec imports: spack.binary_distribution, spack.compiler, spack.compilers, spack.concretize, spack.environment, spack.hash_types, spack.provider_index, spack.repo, spack.spec_parser, spack.store, spack.traverse, spack.variant, spack.version.git_ref_lookup
> spack/subprocess_context imports: spack.environment
> spack/util/gpg imports: spack.bootstrap
> spack/util/package_hash imports: spack.package_base
> spack/util/path imports: spack.config, spack.environment
> spack/util/remote_file_cache imports: spack.util.web
> ```
from which the user can figure out that
`spack/util/remote_file_cache imports: spack.util.web` is the "bottleneck" now.
2025-02-02 20:56:38 -08:00
Massimiliano Culpo
3d82e5c573
Remove pipelines and images based on ppc64le ( #48767 )
2025-01-29 16:36:25 +01:00
Massimiliano Culpo
5085f635dd
Add type hints to spack.util.executable.Executable ( #48468 )
...
* Add type-hints to `spack.util.executable.Executable`
* Add type-hint to input
* Use overload, and remove assertions at calling sites
* Bump mypy to v1.11.2 (working locally), Python to 3.13
2025-01-09 14:16:24 -08:00
dependabot[bot]
e725aa527e
build(deps): bump codecov/codecov-action from 5.0.3 to 5.1.2 ( #48200 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 5.0.3 to 5.1.2.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](05f5a9cfad...1e68e06f1d
2025-01-09 12:33:45 +01:00
Todd Gamblin
f635337af8
Remove years from license headers ( #48352 )
2025-01-02 15:40:28 +01:00
Harmen Stoppels
e9cdcc4af0
build caches: collect files to relocate while tarballing w/o file ( #48212 )
...
A few changes to tarball creation (for build caches):
- do not run file to distinguish binary from text
- file is slow, even when running it in a batched fashion -- it usually reads all bytes and has slow logic to categorize specific types
- we don't need a highly detailed file categorization; a crude categorization of elf, mach-o, text suffices.
detecting elf and mach-o is straightforward and cheap
- detecting utf-8 (and with that ascii) is highly accurate: false positive rate decays exponentially as file size increases. Further it's not only the most common encoding, but the most common file type in package prefixes.
iso-8859-1 is cheaply (but heuristically) detected too, and sufficiently accurate after binaries and utf-8 files are classified earlier
- remove file as a dependency of Spack in general, which makes Spack itself easier to install
- detect file type and need to relocate as part of creating the tarball, which is more cache friendly and thus faster
2024-12-24 10:53:13 -07:00
Massimiliano Culpo
64207e8fe8
Use Ubuntu 22.04 to run unit tests against Python 3.7 ( #48233 )
2024-12-20 10:02:02 +01:00
Harmen Stoppels
fdc85572f3
import-check: bump and simplify ( #48222 )
2024-12-20 09:39:42 +01:00
Todd Gamblin
adbbb91b41
Make unit tests work on ubuntu 24.04 ( #48151 )
...
`kcov` was removed in Ubuntu 24.04, and it is no longer
installable via `apt` in our CI images. Instal it via
Linuxbrew instead, at least until it comes back to Ubuntu.
`subversion` is also not installed on ubuntu 24 by default,
so we have to install it manually.
- [x] Add linuxbrew to linux tests
- [x] Install `kcov` with brew
- [x] Install subversion with `apt`
Signed-off-by: Todd Gamblin <tgamblin@llnl.gov>
2024-12-20 08:20:07 +01:00
dependabot[bot]
f362d45802
build(deps): bump actions/upload-artifact from 4.4.3 to 4.5.0 ( #48180 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.4.3 to 4.5.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](b4b15b8c7c...6f51ac03b9
2024-12-18 13:01:30 -06:00
Massimiliano Culpo
51fb1ed05b
Temporarily pin Ubuntu to v22.04, where we use kcov ( #48152 )
...
Ubuntu doesn't package kcov in v24.04 Since GitHub
started upgrading their runner images, this makes
our CI fail, see e.g.
https://github.com/spack/spack/actions/runs/12366970840/job/34518012887?pr=47854
This is a temporary workaround, while we prepare a
more stable fix.
* Don't run too many unit tests
2024-12-17 11:30:47 +01:00
dependabot[bot]
69faa41c3f
build(deps): bump docker/setup-buildx-action from 3.7.1 to 3.8.0 ( #48150 )
...
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action ) from 3.7.1 to 3.8.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases )
- [Commits](c47758b77c...6524bf65af
2024-12-17 09:00:26 +01:00
Massimiliano Culpo
af6526bb82
ga: add a pylint check to avoid adding open calls without encoding= ( #48099 )
2024-12-13 21:21:26 +01:00
Harmen Stoppels
ba52c4f05d
gha: fix git safe.directory config ( #48041 )
2024-12-11 19:11:44 +01:00
Wouter Deconinck
a72490fc91
coverage.yml: set fail_ci_if_error = false again ( #47986 )
2024-12-09 16:59:44 +01:00
dependabot[bot]
fc105a1a26
build(deps): bump types-six in /.github/workflows/requirements/style ( #47954 )
...
Bumps [types-six](https://github.com/python/typeshed ) from 1.16.21.20241105 to 1.17.0.20241205.
- [Commits](https://github.com/python/typeshed/commits )
---
updated-dependencies:
- dependency-name: types-six
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-08 19:34:20 -06:00
Wouter Deconinck
77e2187e13
coverage.yml: fail_ci_if_error = true ( #47731 )
2024-12-06 11:01:10 -08:00
dependabot[bot]
2e8db0815d
build(deps): bump docker/build-push-action from 6.9.0 to 6.10.0 ( #47819 )
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 6.9.0 to 6.10.0.
- [Release notes](https://github.com/docker/build-push-action/releases )
- [Commits](4f58ea7922...48aba3b46d
2024-11-27 16:29:41 -07:00
Wouter Deconinck
f1faf31735
build-containers: determine latest release tag and push that as latest ( #47742 )
2024-11-25 10:20:58 +01:00
dependabot[bot]
0ff3e86315
build(deps): bump codecov/codecov-action from 5.0.2 to 5.0.3 ( #47683 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 5.0.2 to 5.0.3.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](5c47607acb...05f5a9cfad
2024-11-19 20:40:01 -06:00
dependabot[bot]
df208c1095
build(deps): bump docker/metadata-action from 5.5.1 to 5.6.1 ( #47682 )
...
Bumps [docker/metadata-action](https://github.com/docker/metadata-action ) from 5.5.1 to 5.6.1.
- [Release notes](https://github.com/docker/metadata-action/releases )
- [Commits](8e5442c4ef...369eb591f4
2024-11-19 20:39:45 -06:00
dependabot[bot]
a5ba4f8d91
build(deps): bump codecov/codecov-action from 4.6.0 to 5.0.2 ( #47631 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.6.0 to 5.0.2.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](b9fd7d16f6...5c47607acb
2024-11-15 21:41:14 -06:00
Massimiliano Culpo
4eb7b998e8
Move concretization tests to the same folder ( #47539 )
...
* Move concretization tests to the same folder
Signed-off-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
* Fix for clingo-cffi
---------
Signed-off-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
2024-11-11 19:01:24 +01:00
dependabot[bot]
ebd4ef934c
build(deps): bump types-six in /.github/workflows/requirements/style ( #47454 )
...
Bumps [types-six](https://github.com/python/typeshed ) from 1.16.21.20241009 to 1.16.21.20241105.
- [Commits](https://github.com/python/typeshed/commits )
---
updated-dependencies:
- dependency-name: types-six
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-10 13:03:37 -06:00
Massimiliano Culpo
b97015b791
ci: ci/all must always run, and fail if any job has status "fail" or "canceled" ( #47517 )
...
This means it succeeds when a both jobs have either status "success"
or status "skipped"
2024-11-09 06:04:51 -08:00
Harmen Stoppels
e80d75cbe3
gha: circular imports: pin ( #47248 )
2024-10-27 21:34:32 +01:00
dependabot[bot]
ef220daaca
build(deps): bump actions/checkout from 4.2.1 to 4.2.2 ( #47185 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](eef61447b9...11bd71901b
2024-10-25 09:48:50 -07:00
dependabot[bot]
b34159348f
build(deps): bump actions/setup-python from 5.2.0 to 5.3.0 ( #47209 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](f677139bbe...0b93645e9f
2024-10-25 07:36:14 +02:00
Harmen Stoppels
61cbfc1da0
bootstrap: remove all system gnupg/patchelf executables ( #47165 )
2024-10-24 08:56:42 +02:00
Harmen Stoppels
d8c8074762
bootstrap: add clingo 3.13 binaries and more ( #47126 )
2024-10-24 08:55:14 +02:00
dependabot[bot]
328787b017
build(deps): bump types-six in /.github/workflows/requirements/style ( #47158 )
...
Bumps [types-six](https://github.com/python/typeshed ) from 1.16.21.20240513 to 1.16.21.20241009.
- [Commits](https://github.com/python/typeshed/commits )
---
updated-dependencies:
- dependency-name: types-six
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-23 06:14:11 -06:00
dependabot[bot]
ffab156366
build(deps): bump black in /.github/workflows/requirements/style ( #47117 )
...
Bumps [black](https://github.com/psf/black ) from 24.8.0 to 24.10.0.
- [Release notes](https://github.com/psf/black/releases )
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md )
- [Commits](https://github.com/psf/black/compare/24.8.0...24.10.0 )
---
updated-dependencies:
- dependency-name: black
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-22 18:58:14 +02:00
Massimiliano Culpo
c710a1597f
Reduce the load on clingo-cffi CI job ( #46982 )
...
The purpose of this CI job is to ensure that we
can use a modern clingo to concretize specs, if
e.g. it was installed in a virtual environment
with pip.
Since there is no need to re-test unrelated parts
of Spack, reduce the number of tests we run to just
concretize.py
2024-10-16 09:12:14 +02:00
dependabot[bot]
4b836cb795
build(deps): bump docker/build-push-action from 6.8.0 to 6.9.0 ( #46674 )
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 6.8.0 to 6.9.0.
- [Release notes](https://github.com/docker/build-push-action/releases )
- [Commits](32945a3392...4f58ea7922
2024-10-11 18:25:59 -06:00
