Commit Graph

28372 Commits

Author SHA1 Message Date
Harmen Stoppels
06a2c36a5a Set version to 0.19.2.dev0 2023-04-03 16:51:02 +02:00
Harmen Stoppels
5e0d210734 Set version to 0.19.1 2023-02-09 10:24:14 +01:00
eugeneswalker
e3d4531663 protected runner jobs at uo: trust e4s-uo signing key (#34828) 2023-02-09 10:24:14 +01:00
Harmen Stoppels
9e8e72592d tau: checksum (#33873) 2023-02-08 10:10:38 +01:00
Scott Wittenburg
2d9fa60f53 bindist: use append as a method, not assignable attr (#35379) 2023-02-08 10:10:38 +01:00
eugeneswalker
f3149a6c35 e4s: disable mac stack due to binary relocation issue#32571 (#34560) 2023-02-07 20:13:56 +01:00
Matthias Wolf
403ba23632 Fix path handling in prefix inspections (#35318)
At least with ZSH, prefix inspections containing `./bin` result in a
`$PREFIX/./bin` and result in strange `$PATH` handling.

I.e., `module load git` will prepend `/path/to/git/./bin`, `which git`
will find the right executable, but `git --version` will print the
system one. Normalize the relative path to avoid this behavior.

See also spack/spack#31867.
2023-02-07 20:13:56 +01:00
Gilles Gouaillardet
d62c10ff76 fix libtool filter for Fujitsu compilers (#34916)
Since legit regular expressions are matched, do not pass string=True
to the filter

Refs #34897
2023-02-07 20:13:56 +01:00
Harmen Stoppels
3aa24e5b13 buildcache create: make "file exists" less verbose (#35019)
Currently we print 3 lines of "file exist" warning per tarball, this is
a bit excessive. Instead, it can be a simple single-line tty.warn
message.
2023-02-07 20:13:56 +01:00
Harmen Stoppels
c7200b4327 no python 3.6 anymore on ubuntu 22.04 in relevant setup action? 2023-02-07 20:13:56 +01:00
Dom Heinzeller
5b02b7003a Bug fix for duplicate rpath errors on macOS when creating build caches (#34375) 2023-02-07 20:13:56 +01:00
Harmen Stoppels
f83972ddc4 disable flake warnings for unused imports of types 2023-02-07 20:13:56 +01:00
Harmen Stoppels
fffca98a02 spack mirror create takes local paths only (#34992)
spack mirror create cannot work with urls, so it shouldn't promote local
paths to file urls.
2023-02-07 20:13:56 +01:00
Jonathon Anderson
390112fc76 FileCache: Delete the new cache file on exception (#34623)
The code in FileCache for write_transaction attempts to delete the temporary file when an exception occurs under the context by calling shutil.rmtree. However, rmtree only operates on directories while the rest of FileCache uses normal files. This causes an empty file to be written to the cache key when unneeded.

Use os.remove instead which operates on normal files.

Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
2023-02-07 20:13:56 +01:00
Todd Gamblin
2f3f4ad4da docs: remove monitors and analyzers (#34358)
These experimental features were removed in #31130, but the docs were not.

- [x] remove the `spack monitor` and `spack analyze` docs
2023-02-07 20:13:56 +01:00
Massimiliano Culpo
0f9e07321f Propagate exceptions from Spack python console (#34547)
fixes #34489

Customize sys.excepthook to raise SystemExit when
any unhandled exception reaches the hook.
2023-02-07 20:13:56 +01:00
Massimiliano Culpo
7593b18626 Use a module-like object to propagate changes in the MRO, when setting build env (#34059)
This fixes an issue introduced in #32340, which changed the semantics of the "module"
object passed to the "setup_dependent_package" callback.
2023-02-07 20:13:56 +01:00
Massimiliano Culpo
e964a396c9 Forward lookup of the "run_tests" attribute (#34531)
fixes #34518

Fix an issue due to the MRO chain of the package wrapper
during build. Before this PR we were always returning
False when the builder object was created before the
run_tests method was monkey patched.
2023-02-07 20:13:56 +01:00
Massimiliano Culpo
8d45404b5b scons: fix signature for install_args (#34481) 2023-02-07 20:13:56 +01:00
Chris Green
7055061635 PackageBase should not define builder legacy attributes (#33942)
* Add a regression test for 33928

* PackageBase should not set `(build|install)_time_test_callbacks`

* Fix audits by preserving the current semantic

Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
2023-02-07 20:13:56 +01:00
Massimiliano Culpo
5e9799db4a Improve error message for requirements (#33988)
refers #33985
2023-02-07 20:13:56 +01:00
Harmen Stoppels
4258fbbed3 Fix combine_phase_logs text encoding issues (#34657)
Avoid text decoding and encoding when combining log files, instead
combine in binary mode.

Also do a buffered copy which is sometimes faster for large log files.
2023-02-07 20:13:56 +01:00
Scott Wittenburg
db8fcbbee4 ci: restore ability to reproduce gitlab job failures (#33953) 2023-02-07 20:13:56 +01:00
Harmen Stoppels
d33c990278 uninstall: fix accidental cubic complexity (#34005)
* uninstall: fix accidental cubic complexity

Currently spack uninstall runs in worst case cubic time complexity
thanks to traversal during traversal during traversal while collecting
the specs to be uninstalled.

Also brings down the number of error messages printed to something
linear in the amount of matching specs instead of quadratic.
2023-02-07 20:13:56 +01:00
Massimiliano Culpo
59dd405626 Fix a bug/typo in a config_values.py fixture (#33886) 2023-02-07 20:13:56 +01:00
Harmen Stoppels
dbbf7dc969 Fixup: start the timer before the phase (#33917) 2023-02-07 20:13:56 +01:00
Harmen Stoppels
8a71aa874f Fix incorrect timer (#33900)
Revamp the timer so we always have a designated begin and end.

Fix a bug where the phase timer was stopped before the phase started,
resulting in incorrect timing reports in timers.json.
2023-02-07 20:13:56 +01:00
Michael Kuhn
0766f63182 docs: fix typo (#33926) 2023-02-07 20:13:56 +01:00
Harmen Stoppels
380fedb7bc docs: fix typo in multiple build systems 2023-02-07 20:13:56 +01:00
Harmen Stoppels
33cc47f6d3 Revert "Hotfix/namespace (#33870)"
This reverts commit a86911246a.
2023-02-07 20:13:56 +01:00
Harmen Stoppels
5935f9c8a0 Set version to 0.19.1.dev0 2023-02-07 20:13:56 +01:00
Greg Becker
a86911246a
Hotfix/namespace (#33870)
Concretize namespaces

Add new concretizer option `enable_node_namespace` that enables namespace-specific concretization
2022-11-13 05:08:39 -06:00
Greg Becker
cd94827c5f
bump release version for tutorial command (#33859)
* bump release version for tutorial command
* Use spack.spack_version_info as source of truth

Co-authored-by: Todd Gamblin <gamblin2@llnl.gov>
2022-11-12 11:41:59 -08:00
Gregory Becker
bb8b4f9979
ensure view projections for extensions always point to extendee 2022-11-11 09:30:32 -08:00
Harmen Stoppels
fc7a16e77e docs: updates related to extensions (#33837) 2022-11-11 16:31:25 +01:00
Todd Gamblin
e633e57297 Update CHANGELOG.md for v0.19.0
Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
2022-11-11 16:29:30 +01:00
Todd Gamblin
7b74fab12f
Update SECURITY.md for v0.19 2022-11-11 01:06:17 -08:00
Todd Gamblin
005c7cd353
Version is now v0.19.0. 2022-11-11 00:50:50 -08:00
Harmen Stoppels
0f54a63dfd
remove activate/deactivate support in favor of environments (#29317)
Environments and environment views have taken over the role of `spack activate/deactivate`, and we should deprecate these commands for several reasons:

- Global activation is a really poor idea:
   - Install prefixes should be immutable; since they can have multiple, unrelated dependents; see below
   - Added complexity elsewhere: verification of installations, tarballs for build caches, creation of environment views of packages with unrelated extensions "globally activated"... by removing the feature, it gets easier for people to contribute, and we'd end up with fewer bugs due to edge cases.
- Environment accomplish the same thing for non-global "activation" i.e. `spack view`, but better.

Also we write in the docs:

```
However, Spack global activations have two potential drawbacks:

#. Activated packages that involve compiled C extensions may still
   need their dependencies to be loaded manually.  For example,
   ``spack load openblas`` might be required to make ``py-numpy``
   work.

#. Global activations "break" a core feature of Spack, which is that
   multiple versions of a package can co-exist side-by-side.  For example,
   suppose you wish to run a Python package in two different
   environments but the same basic Python --- one with
   ``py-numpy@1.7`` and one with ``py-numpy@1.8``.  Spack extensions
   will not support this potential debugging use case.
```

Now that environments are established and views can take over the role of activation
non-destructively, we can remove global activation/deactivation.
2022-11-11 00:50:07 -08:00
Greg Becker
f11778bb02
remove deprecated top-level module config (#33828)
* remove deprecated top-level module config per deprecation in 0.18
2022-11-10 23:35:33 -08:00
Brian Van Essen
3437926cde
Fixed a bug where the external HIP library is found in a nested directory, even on newer releases of ROCm. (#33772) 2022-11-10 23:32:55 -08:00
Pranith
d25375da55
emacs: Add version 28.2 (#33255) 2022-11-11 04:07:11 +01:00
Yang Zongze
0b302034df
global: add --with-ncurses with prefix to configure (#33136) 2022-11-11 03:40:03 +01:00
Seth R. Johnson
b9f69a8dfa
go-bootstrap: improve error message for Monterey (#31800)
Co-authored-by: Seth R. Johnson <johnsonsr@ornl.gov>
2022-11-11 02:22:37 +01:00
Loïc Pottier
c3e9aeeed0
redis-plus-plus: added initial support (#33803)
* redis-plus-plus: added initial support
* redis-plus-plus: use cmake arg provided by Spack
* redis-plus-plus: oups tiny typo

Signed-off-by: Loïc Pottier <pottier1@llnl.gov>
Signed-off-by: Loïc Pottier <lpottier@arnor>
Co-authored-by: Loïc Pottier <lpottier@arnor>
2022-11-10 17:19:45 -08:00
Greg Becker
277234c044
remove deprecated concretization environment key (#33774) 2022-11-11 00:11:52 +00:00
Harmen Stoppels
0077a25639
Use bfs order in spack find --deps tree (#33782)
* Use bfs order in spack find --deps tree
* fix printing tests
2022-11-10 15:39:07 -08:00
Massimiliano Culpo
6a3e20023e
Delete directory with vestigial configuration file (#33825) 2022-11-11 00:10:29 +01:00
MatthewLieber
f92987b11f
adding sha for 7.0 release (#33823)
Co-authored-by: Matthew Lieber <lieber.31@osu.edu>
2022-11-10 14:24:05 -08:00
Satish Balay
61f198e8af
xsdk: deprecate 0.6.0, and remove older deprecated releases (#33815)
xsdk-examples: deprecate @0.2.0, remove @0.1.0 in sync with older xsdk releases
2022-11-10 14:16:17 -08:00