Harmen Stoppels
e9cdcc4af0
build caches: collect files to relocate while tarballing w/o file ( #48212 )
...
A few changes to tarball creation (for build caches):
- do not run file to distinguish binary from text
- file is slow, even when running it in a batched fashion -- it usually reads all bytes and has slow logic to categorize specific types
- we don't need a highly detailed file categorization; a crude categorization of elf, mach-o, text suffices.
detecting elf and mach-o is straightforward and cheap
- detecting utf-8 (and with that ascii) is highly accurate: false positive rate decays exponentially as file size increases. Further it's not only the most common encoding, but the most common file type in package prefixes.
iso-8859-1 is cheaply (but heuristically) detected too, and sufficiently accurate after binaries and utf-8 files are classified earlier
- remove file as a dependency of Spack in general, which makes Spack itself easier to install
- detect file type and need to relocate as part of creating the tarball, which is more cache friendly and thus faster
2024-12-24 10:53:13 -07:00
Massimiliano Culpo
64207e8fe8
Use Ubuntu 22.04 to run unit tests against Python 3.7 ( #48233 )
2024-12-20 10:02:02 +01:00
Todd Gamblin
adbbb91b41
Make unit tests work on ubuntu 24.04 ( #48151 )
...
`kcov` was removed in Ubuntu 24.04, and it is no longer
installable via `apt` in our CI images. Instal it via
Linuxbrew instead, at least until it comes back to Ubuntu.
`subversion` is also not installed on ubuntu 24 by default,
so we have to install it manually.
- [x] Add linuxbrew to linux tests
- [x] Install `kcov` with brew
- [x] Install subversion with `apt`
Signed-off-by: Todd Gamblin <tgamblin@llnl.gov>
2024-12-20 08:20:07 +01:00
dependabot[bot]
f362d45802
build(deps): bump actions/upload-artifact from 4.4.3 to 4.5.0 ( #48180 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.4.3 to 4.5.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](b4b15b8c7c...6f51ac03b9
2024-12-18 13:01:30 -06:00
Massimiliano Culpo
51fb1ed05b
Temporarily pin Ubuntu to v22.04, where we use kcov ( #48152 )
...
Ubuntu doesn't package kcov in v24.04 Since GitHub
started upgrading their runner images, this makes
our CI fail, see e.g.
https://github.com/spack/spack/actions/runs/12366970840/job/34518012887?pr=47854
This is a temporary workaround, while we prepare a
more stable fix.
* Don't run too many unit tests
2024-12-17 11:30:47 +01:00
Harmen Stoppels
ba52c4f05d
gha: fix git safe.directory config ( #48041 )
2024-12-11 19:11:44 +01:00
Massimiliano Culpo
4eb7b998e8
Move concretization tests to the same folder ( #47539 )
...
* Move concretization tests to the same folder
Signed-off-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
* Fix for clingo-cffi
---------
Signed-off-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
2024-11-11 19:01:24 +01:00
dependabot[bot]
ef220daaca
build(deps): bump actions/checkout from 4.2.1 to 4.2.2 ( #47185 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](eef61447b9...11bd71901b
2024-10-25 09:48:50 -07:00
dependabot[bot]
b34159348f
build(deps): bump actions/setup-python from 5.2.0 to 5.3.0 ( #47209 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](f677139bbe...0b93645e9f
2024-10-25 07:36:14 +02:00
Harmen Stoppels
d8c8074762
bootstrap: add clingo 3.13 binaries and more ( #47126 )
2024-10-24 08:55:14 +02:00
Massimiliano Culpo
c710a1597f
Reduce the load on clingo-cffi CI job ( #46982 )
...
The purpose of this CI job is to ensure that we
can use a modern clingo to concretize specs, if
e.g. it was installed in a virtual environment
with pip.
Since there is no need to re-test unrelated parts
of Spack, reduce the number of tests we run to just
concretize.py
2024-10-16 09:12:14 +02:00
dependabot[bot]
8d651625f7
build(deps): bump actions/upload-artifact from 4.4.0 to 4.4.3 ( #46895 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.4.0 to 4.4.3.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](50769540e7...b4b15b8c7c
2024-10-10 11:38:56 -05:00
dependabot[bot]
675be13a7b
build(deps): bump actions/checkout from 4.2.0 to 4.2.1 ( #46854 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](d632683dd7...eef61447b9
2024-10-10 00:18:09 -06:00
Harmen Stoppels
486ff2beac
gha: brew gnupg2 is now gnupg ( #46689 )
2024-10-01 22:23:56 +02:00
dependabot[bot]
941c8daabe
build(deps): bump actions/checkout from 4.1.7 to 4.2.0 ( #46584 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.7 to 4.2.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](692973e3d9...d632683dd7
2024-09-27 08:22:47 +02:00
Todd Gamblin
930e711771
coverage: only upload to codecov once ( #46385 )
...
Historically, every PR, push, etc. to Spack generates a bunch of jobs, each of which
uploads its coverage report to codecov independently. This means that we get annoying
partial coverage numbers when only a few of the jobs have finished, and frequently
codecov is bad at understanding when to merge reports for a given PR. The numbers of the
site can be weird as a result.
This restructures our coverage handling so that we do all the merging ourselves and
upload exactly one report per GitHub actions workflow. In practice, that means that
every push to every PR will get exactly one coverage report and exactly one coverage
number reported. I think this will at least partially restore peoples' faith in what
codecov is telling them, and it might even make codecov handle Spack a bit better, since
this reduces the report burden by ~7x.
- [x] test and audit jobs now upload artifacts for coverage
- [x] add a new job that downloads artifacts and merges coverage reports together
- [x] set `paths` section of `pyproject.toml` so that cross-platform clone locations are merged
- [x] upload to codecov once, at the end of the workflow
Signed-off-by: Todd Gamblin <tgamblin@llnl.gov>
2024-09-16 19:18:21 -07:00
dependabot[bot]
04bdff33ad
build(deps): bump actions/setup-python from 5.1.1 to 5.2.0 ( #46129 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.1.1 to 5.2.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](39cd14951b...f677139bbe
2024-08-31 11:51:49 -05:00
Massimiliano Culpo
2079b888c8
Remove the old concretizer ( #45215 )
...
The old concretizer is still used to bootstrap clingo from source. If we switch to a DAG model
where compilers are treated as nodes, we need to either:
1. fix the old concretizer to support this (which is a lot of work and possibly research), or
2. bootstrap `clingo` without the old concretizer.
This PR takes the second approach and gets rid of the old concretizer code. To bootstrap
`clingo`, we store some concrete spec prototypes as JSON, select one according to the
coarse-grained system architecture, and tweak them according to the current host.
The old concretizer and related dead code are removed. In particular, this removes
`Spec.normalize()` and related methods, which were used in many unit-tests to set
up the test context. The tests have been updated not to use `normalize()`.
- [x] Bootstrap clingo concretization based on a JSON file
- [x] Bootstrap clingo *before* patchelf
- [x] Remove any use of the old concretizer, including:
* Remove only_clingo and only_original fixtures
* Remove _old_concretize and _new_concretize
* Remove _concretize_together_old
* Remove _concretize_together_new
* Remove any use of `SPACK_TEST_SOLVER`
* Simplify CI jobs
- [x] ensure bootstrapping `clingo` works on on Darwin and Windows
- [x] Raise an intelligible error when a compiler is missing
- [x] Ensure bootstrapping works on FreeBSD
- [x] remove normalize and related methods
Signed-off-by: Todd Gamblin <tgamblin@llnl.gov>
2024-08-10 16:12:27 -07:00
dependabot[bot]
e7946a3a41
build(deps): bump actions/checkout from 4.1.6 to 4.1.7 ( #44693 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](a5ac7e51b4...692973e3d9
2024-07-11 15:32:04 +02:00
dependabot[bot]
fb89337b04
build(deps): bump actions/setup-python from 5.1.0 to 5.1.1 ( #45182 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](82c7e631bb...39cd14951b
2024-07-11 05:39:08 +02:00
Alec Scott
7c5fbee327
Improve organization of CI workflow scripts and pip requirements ( #45037 )
2024-07-09 04:46:09 +02:00
dependabot[bot]
42ac1f0cb2
build(deps): bump codecov/codecov-action from 4.4.1 to 4.5.0 ( #44710 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.4.1 to 4.5.0.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](125fc84a9a...e28ff129e5
2024-06-13 16:45:24 -07:00
Massimiliano Culpo
c6cc125e22
Remove failing unit-test on Windows ( #44627 )
2024-06-08 09:36:22 +02:00
dependabot[bot]
7bdb106b1b
--- ( #44281 )
...
updated-dependencies:
- dependency-name: codecov/codecov-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-21 13:15:05 +02:00
dependabot[bot]
2a16d8bfa8
build(deps): bump codecov/codecov-action from 4.3.1 to 4.4.0 ( #44195 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.3.1 to 4.4.0.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](5ecb98a3c6...6d798873df
2024-05-17 18:46:17 +02:00
dependabot[bot]
9d591f9f7c
build(deps): bump actions/checkout from 4.1.5 to 4.1.6 ( #44234 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.5 to 4.1.6.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](44c2b7a8a4...a5ac7e51b4
2024-05-17 10:57:08 +02:00
Massimiliano Culpo
e60f6f4a6e
CI/Update macOS runners: macos-latest switched to macos-14 ( #44094 )
...
macos-latest switched to macos-14, so now we are running
two identical jobs.
2024-05-09 14:28:17 +02:00
dependabot[bot]
2bcba57757
build(deps): bump actions/checkout from 4.1.4 to 4.1.5 ( #44045 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.4 to 4.1.5.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](0ad4b8fada...44c2b7a8a4
2024-05-08 09:22:48 -07:00
dependabot[bot]
df443a38d6
build(deps): bump actions/checkout from 4.1.2 to 4.1.4 ( #43831 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.2 to 4.1.4.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](9bb56186c3...0ad4b8fada
2024-05-04 15:49:26 -07:00
dependabot[bot]
49a8634584
build(deps): bump codecov/codecov-action from 4.3.0 to 4.3.1 ( #43945 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](84508663e9...5ecb98a3c6
2024-05-04 15:39:42 -07:00
dependabot[bot]
7eb2e704b6
build(deps): bump codecov/codecov-action from 4.1.1 to 4.3.0 ( #43562 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.1.1 to 4.3.0.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](c16abc29c9...84508663e9
2024-04-15 17:34:31 +02:00
dependabot[bot]
8f76f1b0d8
build(deps): bump actions/setup-python from 5.0.0 to 5.1.0 ( #43384 )
2024-03-27 10:49:45 +01:00
dependabot[bot]
4cab6f3af5
build(deps): bump codecov/codecov-action from 4.1.0 to 4.1.1 ( #43385 )
2024-03-27 10:49:33 +01:00
Harmen Stoppels
5d0ef9e4f4
ci: remove outdated version comments ( #43389 )
2024-03-27 09:26:12 +01:00
Harmen Stoppels
e145baf619
codecov: verbose: true ( #43388 )
2024-03-27 09:15:34 +01:00
Harmen Stoppels
7e9caed8c2
ci: fix codecov upload ( #43382 )
2024-03-26 22:49:26 +01:00
Massimiliano Culpo
0841050d20
Add macos-14 as a runner (Apple M1) ( #42728 )
...
* Add macos-14 as a runner (Apple M1)
* Mark a test xfail
We need to check later if this test needs modifications
on Apple Silicon chips.
---------
Co-authored-by: Harmen Stoppels <me@harmenstoppels.nl>
Co-authored-by: alalazo <alalazo@users.noreply.github.com>
2024-03-26 12:36:21 -07:00
dependabot[bot]
dbdf5bacc4
build(deps): bump actions/checkout from 4.1.1 to 4.1.2 ( #43152 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](b4ffde65f4...9bb56186c3
2024-03-14 05:55:08 +01:00
dependabot[bot]
8dcf860888
build(deps): bump codecov/codecov-action from 4.0.2 to 4.1.0 ( #42860 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.0.2 to 4.1.0.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](0cfda1dd0a...54bcd8715e
2024-03-02 10:39:09 -08:00
dependabot[bot]
38d821461c
build(deps): bump codecov/codecov-action from 4.0.1 to 4.0.2 ( #42831 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.0.1 to 4.0.2.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](e0b68c6749...0cfda1dd0a
2024-02-24 12:26:30 -08:00
dependabot[bot]
9c4e44a0ad
build(deps): bump codecov/codecov-action from 4.0.0 to 4.0.1 ( #42439 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](f30e4959ba...e0b68c6749
2024-02-02 12:20:29 +01:00
dependabot[bot]
eea06de6df
build(deps): bump codecov/codecov-action from 3.1.6 to 4.0.0 ( #42415 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.1.6 to 4.0.0.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](ab904c41d6...f30e4959ba
2024-02-01 09:13:52 +01:00
dependabot[bot]
a171fe3565
build(deps): bump codecov/codecov-action from 3.1.5 to 3.1.6 ( #42385 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.1.5 to 3.1.6.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](4fe8c5f003...ab904c41d6
2024-01-31 09:54:11 +01:00
dependabot[bot]
62ed5ee318
build(deps): bump codecov/codecov-action from 3.1.4 to 3.1.5 ( #42295 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](eaaf4bedf3...4fe8c5f003
2024-01-29 16:27:44 +01:00
dependabot[bot]
24a59ffd36
build(deps): bump actions/setup-python from 4.8.0 to 5.0.0 ( #41474 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.8.0 to 5.0.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](b64ffcaf5b...0a5c615913
2023-12-07 09:55:55 +01:00
dependabot[bot]
d1c3374ccb
build(deps): bump actions/setup-python from 4.7.1 to 4.8.0 ( #41441 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.7.1 to 4.8.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](65d7f2d534...b64ffcaf5b
2023-12-06 09:20:14 +01:00
Harmen Stoppels
fcb3d62093
unit tests: use --verbose to see order on macos ( #41314 )
2023-11-29 11:29:17 +01:00
dependabot[bot]
f2ba25e09d
build(deps): bump actions/checkout from 4.1.0 to 4.1.1 ( #40584 )
2023-10-19 23:04:40 +02:00
Massimiliano Culpo
861bb4d35a
Update bootstrap buildcache to support Python 3.12 ( #40404 )
...
* Add support for Python 3.12
* Use optimized build of clingo
2023-10-11 19:03:17 +02:00
dependabot[bot]
b7cb3462d4
build(deps): bump actions/setup-python from 4.7.0 to 4.7.1 ( #40287 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.7.0 to 4.7.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](61a6322f88...65d7f2d534
2023-10-03 12:28:02 +02:00
