Harmen Stoppels
5d87166c07
gha: standalone import-check ( #48873 )
2025-02-04 22:18:30 +01:00
Harmen Stoppels
9642f3f49a
import-check: enable color output ( #48842 )
2025-02-03 11:02:21 +01:00
Harmen Stoppels
763b35a2e0
import-check: improve how problematic imports are displayed ( #48825 )
...
The import-check action now presents problematic import statements
introduced by the PR better.
The idea is roughly:
* Let (V₁, E₁) be the graph of modules as vertices and import statements
as edges before the change
* Let (V₂, E₂) be the graph after the code change, which is typically a small
perturbation of (V₁, E₁).
* X₁ = FAS(V₁, E₁) is the feedback arc set before (a minimal set of edges to
delete to make it acyclic)
* X₂ = FAS(V₂, E₂ ∖ X₁) is the feedback arc set after deletion of the minimal
set of edges that made the old graph acyclic.
* X₃ = FAS(V₂, E₂) is the feedback arc set after
Previously I displayed X₁ and X₃ and users had to diff themselves.
Now, I'm showing X₂, which is a small set, typically directly related to
code changes.
However, it can be that a small code change adding say 2 problematic imports
creates a completely different solution X₃ that only requires deletion of just 1
different import. In that case the user is informed that they can potentially do
less work.
So for PR #48784 the output is now:
> The overall number of problematic import statements increased by 1 from 31 to 32.
> This is likely a direct consequence of the following import statements:
>
> ```
> spack/config imports: spack.spec, spack.util.path, spack.util.remote_file_cache
> ```
>
> However, instead of removing 3 import statements, it is sufficient to remove only 1
> import statement from the following list:
>
> ```
> spack/concretize imports: spack.bootstrap, spack.solver.asp
> spack/environment imports: spack.bootstrap, spack.environment
> spack/fetch_strategy imports: spack.version.git_ref_lookup
> spack/install_test imports: spack.build_environment, spack.package_base
> spack/modules imports: spack.modules
> spack/platforms imports: spack.config
> spack/relocate imports: spack.bootstrap
> spack/repo imports: spack.package_base, spack.patch, spack.tag
> spack/spec imports: spack.binary_distribution, spack.compiler, spack.compilers, spack.concretize, spack.environment, spack.hash_types, spack.provider_index, spack.repo, spack.spec_parser, spack.store, spack.traverse, spack.variant, spack.version.git_ref_lookup
> spack/subprocess_context imports: spack.environment
> spack/util/gpg imports: spack.bootstrap
> spack/util/package_hash imports: spack.package_base
> spack/util/path imports: spack.config, spack.environment
> spack/util/remote_file_cache imports: spack.util.web
> ```
from which the user can figure out that
`spack/util/remote_file_cache imports: spack.util.web` is the "bottleneck" now.
2025-02-02 20:56:38 -08:00
Massimiliano Culpo
5085f635dd
Add type hints to spack.util.executable.Executable ( #48468 )
...
* Add type-hints to `spack.util.executable.Executable`
* Add type-hint to input
* Use overload, and remove assertions at calling sites
* Bump mypy to v1.11.2 (working locally), Python to 3.13
2025-01-09 14:16:24 -08:00
Harmen Stoppels
fdc85572f3
import-check: bump and simplify ( #48222 )
2024-12-20 09:39:42 +01:00
Massimiliano Culpo
af6526bb82
ga: add a pylint check to avoid adding open calls without encoding= ( #48099 )
2024-12-13 21:21:26 +01:00
Harmen Stoppels
ba52c4f05d
gha: fix git safe.directory config ( #48041 )
2024-12-11 19:11:44 +01:00
Harmen Stoppels
e80d75cbe3
gha: circular imports: pin ( #47248 )
2024-10-27 21:34:32 +01:00
dependabot[bot]
ef220daaca
build(deps): bump actions/checkout from 4.2.1 to 4.2.2 ( #47185 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](eef61447b9...11bd71901b
2024-10-25 09:48:50 -07:00
dependabot[bot]
b34159348f
build(deps): bump actions/setup-python from 5.2.0 to 5.3.0 ( #47209 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](f677139bbe...0b93645e9f
2024-10-25 07:36:14 +02:00
Nathan Hanford
af62a062cc
Installer: rewire spliced specs via RewireTask ( #39136 )
...
This PR allows users to configure explicit splicing replacement of an abstract spec in the concretizer.
concretizer:
splice:
explicit:
- target: mpi
replacement: mpich/abcdef
transitive: true
This config block would mean "for any spec that concretizes to use mpi, splice in mpich/abcdef in place of the mpi it would naturally concretize to use. See #20262 , #26873 , #27919 , and #46382 for PRs enabling splicing in the Spec object. This PR will be the first place the splice method is used in a user-facing manner. See https://spack.readthedocs.io/en/latest/spack.html#spack.spec.Spec.splice for more information on splicing.
This will allow users to reuse generic public binaries while splicing in the performant local mpi implementation on their system.
In the config file, the target may be any abstract spec. The replacement must be a spec that includes an abstract hash `/abcdef`. The transitive key is optional, defaulting to true if left out.
Two important items to note:
1. When writing explicit splice config, the user is in charge of ensuring that the replacement specs they use are binary compatible with whatever targets they replace. In practice, this will likely require either specific knowledge of what packages will be installed by the user's workflow, or somewhat more specific abstract "target" specs for splicing, to ensure binary compatibility.
2. Explicit splices can cause the output of the concretizer not to satisfy the input. For example, using the config above and consider a package in a binary cache `hdf5/xyzabc` that depends on mvapich2. Then the command `spack install hdf5/xyzabc` will instead install the result of splicing `mpich/abcdef` into `hdf5/xyzabc` in place of whatever mvapich2 spec it previously depended on. When this occurs, a warning message is printed `Warning: explicit splice configuration has caused the the concretized spec {concrete_spec} not to satisfy the input spec {input_spec}".
Highlighted technical details of implementation:
1. This PR required modifying the installer to have two separate types of Tasks, `RewireTask` and `BuildTask`. Spliced specs are queued as `RewireTask` and standard specs are queued as `BuildTask`. Each spliced spec retains a pointer to its build_spec for provenance. If a RewireTask is dequeued and the associated `build_spec` is neither available in the install_tree nor from a binary cache, the RewireTask is requeued with a new dependency on a BuildTask for the build_spec, and BuildTasks are queued for the build spec and its dependencies.
2. Relocation is modified so that a spack binary can be simultaneously installed and rewired. This ensures that installing the build_spec is not necessary when splicing from a binary cache.
3. The splicing model is modified to more accurately represent build dependencies -- that is, spliced specs do not have build dependencies, as spliced specs are never built. Their build_specs retain the build dependencies, as they may be built as part of installing the spliced spec.
4. There were vestiges of the compiler bootstrapping logic that were not removed in #46237 because I asked alalazo to leave them in to avoid making the rebase for this PR harder than it needed to be. Those last remains are removed in this PR.
Co-authored-by: Nathan Hanford <hanford1@llnl.gov>
Co-authored-by: Gregory Becker <becker33@llnl.gov>
Co-authored-by: Tamara Dahlgren <dahlgren1@llnl.gov>
2024-10-10 15:48:58 -07:00
dependabot[bot]
675be13a7b
build(deps): bump actions/checkout from 4.2.0 to 4.2.1 ( #46854 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](d632683dd7...eef61447b9
2024-10-10 00:18:09 -06:00
dependabot[bot]
941c8daabe
build(deps): bump actions/checkout from 4.1.7 to 4.2.0 ( #46584 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.7 to 4.2.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](692973e3d9...d632683dd7
2024-09-27 08:22:47 +02:00
Harmen Stoppels
28e3295fb0
Add GHA for circular imports regressions ( #46436 )
2024-09-18 09:07:23 +02:00
dependabot[bot]
04bdff33ad
build(deps): bump actions/setup-python from 5.1.1 to 5.2.0 ( #46129 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.1.1 to 5.2.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](39cd14951b...f677139bbe
2024-08-31 11:51:49 -05:00
dependabot[bot]
e7946a3a41
build(deps): bump actions/checkout from 4.1.6 to 4.1.7 ( #44693 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](a5ac7e51b4...692973e3d9
2024-07-11 15:32:04 +02:00
dependabot[bot]
fb89337b04
build(deps): bump actions/setup-python from 5.1.0 to 5.1.1 ( #45182 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](82c7e631bb...39cd14951b
2024-07-11 05:39:08 +02:00
Alec Scott
7c5fbee327
Improve organization of CI workflow scripts and pip requirements ( #45037 )
2024-07-09 04:46:09 +02:00
dependabot[bot]
9d591f9f7c
build(deps): bump actions/checkout from 4.1.5 to 4.1.6 ( #44234 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.5 to 4.1.6.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](44c2b7a8a4...a5ac7e51b4
2024-05-17 10:57:08 +02:00
dependabot[bot]
2bcba57757
build(deps): bump actions/checkout from 4.1.4 to 4.1.5 ( #44045 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.4 to 4.1.5.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](0ad4b8fada...44c2b7a8a4
2024-05-08 09:22:48 -07:00
dependabot[bot]
df443a38d6
build(deps): bump actions/checkout from 4.1.2 to 4.1.4 ( #43831 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.2 to 4.1.4.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](9bb56186c3...0ad4b8fada
2024-05-04 15:49:26 -07:00
dependabot[bot]
8f76f1b0d8
build(deps): bump actions/setup-python from 5.0.0 to 5.1.0 ( #43384 )
2024-03-27 10:49:45 +01:00
Harmen Stoppels
0d4665583b
ci: inherit secrets in local workflows ( #43391 )
2024-03-27 09:48:14 +01:00
Harmen Stoppels
5d0ef9e4f4
ci: remove outdated version comments ( #43389 )
2024-03-27 09:26:12 +01:00
dependabot[bot]
dbdf5bacc4
build(deps): bump actions/checkout from 4.1.1 to 4.1.2 ( #43152 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](b4ffde65f4...9bb56186c3
2024-03-14 05:55:08 +01:00
dependabot[bot]
24a59ffd36
build(deps): bump actions/setup-python from 4.8.0 to 5.0.0 ( #41474 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.8.0 to 5.0.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](b64ffcaf5b...0a5c615913
2023-12-07 09:55:55 +01:00
dependabot[bot]
d1c3374ccb
build(deps): bump actions/setup-python from 4.7.1 to 4.8.0 ( #41441 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.7.1 to 4.8.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](65d7f2d534...b64ffcaf5b
2023-12-06 09:20:14 +01:00
dependabot[bot]
f2ba25e09d
build(deps): bump actions/checkout from 4.1.0 to 4.1.1 ( #40584 )
2023-10-19 23:04:40 +02:00
dependabot[bot]
b7cb3462d4
build(deps): bump actions/setup-python from 4.7.0 to 4.7.1 ( #40287 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.7.0 to 4.7.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](61a6322f88...65d7f2d534
2023-10-03 12:28:02 +02:00
dependabot[bot]
9ec372a86c
build(deps): bump actions/checkout from 4.0.0 to 4.1.0 ( #40172 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](3df4ab11eb...8ade135a41
2023-09-24 16:08:15 +02:00
Massimiliano Culpo
5c10c29923
Pin the version of tools used in CI, have dependabot manage their version ( #40066 )
2023-09-22 10:33:01 -07:00
dependabot[bot]
06b6b05dbd
build(deps): bump actions/checkout from 3.6.0 to 4.0.0 ( #39789 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.6.0 to 4.0.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](f43a0e5ff2...3df4ab11eb
2023-09-05 09:52:14 +02:00
dependabot[bot]
7f0f1b63d6
build(deps): bump actions/checkout from 3.5.3 to 3.6.0 ( #39617 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.5.3 to 3.6.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](c85c95e3d7...f43a0e5ff2
2023-08-25 08:27:56 +02:00
dependabot[bot]
9e0f1f8998
build(deps): bump actions/setup-python from 4.6.1 to 4.7.0 ( #38887 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.6.1 to 4.7.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](bd6b4b6205...61a6322f88
2023-07-14 15:48:29 +00:00
Massimiliano Culpo
c8d95512fc
bootstrap: add minimum versions required for flake8 and pytest ( #38322 )
2023-06-12 12:29:35 +02:00
dependabot[bot]
a73f511404
build(deps): bump actions/checkout from 3.5.2 to 3.5.3 ( #38305 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.5.2 to 3.5.3.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](8e5e7e5ab8...c85c95e3d7
2023-06-10 18:45:37 -07:00
dependabot[bot]
582ebee74c
build(deps): bump actions/setup-python from 4.6.0 to 4.6.1 ( #37894 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](57ded4d7d5...bd6b4b6205
2023-05-28 09:58:14 +02:00
Harmen Stoppels
a0e7ca94b2
gha bootstrap-dev-rhel8: configure git safe.directory ( #37702 )
...
git has been updated to something more recent
2023-05-16 15:21:42 +02:00
Massimiliano Culpo
68a4b2e4e4
GitHub Actions: do not install six in CI ( #37361 )
...
* GitHub Actions: do not install six in CI
* Remove workflow code that was commented out
* Remove any use of "six" from packages
2023-05-02 13:28:24 -04:00
dependabot[bot]
056eb659bb
build(deps): bump actions/setup-python from 4.5.0 to 4.6.0 ( #37078 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](d27e3f3d7c...57ded4d7d5
2023-04-21 11:40:37 +02:00
dependabot[bot]
2651def9fa
build(deps): bump actions/checkout from 3.5.1 to 3.5.2 ( #36848 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.5.1 to 3.5.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](83b7061638...8e5e7e5ab8
2023-04-15 14:37:52 +02:00
dependabot[bot]
4a44e4bed9
build(deps): bump actions/checkout from 3.5.0 to 3.5.1 ( #36815 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.5.0 to 3.5.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](8f4b7f8486...83b7061638
2023-04-13 20:28:26 +02:00
dependabot[bot]
e0570c819c
build(deps): bump actions/checkout from 3.4.0 to 3.5.0 ( #36418 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](24cb908017...8f4b7f8486
2023-03-27 09:16:07 +00:00
Massimiliano Culpo
d0d5526110
Add a pre-check job to bootstrap the environment on Python 3.6 ( #36358 )
...
* Add a pre-check job that just bootstrap the environment on Python 3.6
* py-typing-extension: restore information on Python 3.6 installation
* Fix job name, try to run quick test on installed python packages
2023-03-24 04:08:42 +00:00
dependabot[bot]
4e060ba933
build(deps): bump actions/checkout from 3.3.0 to 3.4.0 ( #36140 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](ac59398561...24cb908017
2023-03-17 10:58:57 +01:00
Adam J. Stewart
603569e321
Style: black 23, skip magic trailing comma ( #35351 )
...
* Style: black 23, skip magic trailing commas
* isort should use same line length as black
* Fix unused import
* Update version of black used in CI
* Update new packages
* Update new packages
2023-02-16 23:06:12 -06:00
Massimiliano Culpo
46466302a9
Pin black to 22.12.0 to avoid spurious style changes ( #35282 )
...
We need to sync changes on major versions with
spackbot, to avoid the bot saying everything is
allright and have CI failing nonetheless.
2023-02-01 15:45:12 +01:00
dependabot[bot]
f0672bbaf8
build(deps): bump actions/checkout from 3.2.0 to 3.3.0 ( #34829 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](755da8c3cf...ac59398561
2023-01-17 10:02:31 +01:00
dependabot[bot]
d45c228401
build(deps): bump actions/setup-python from 4.4.0 to 4.5.0 ( #34939 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.4.0 to 4.5.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](5ccb29d877...d27e3f3d7c
2023-01-16 10:33:12 +01:00
dependabot[bot]
9759331f43
build(deps): bump actions/setup-python from 4.3.1 to 4.4.0 ( #34667 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.3.1 to 4.4.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](2c3dd9e7e2...5ccb29d877
2022-12-29 14:57:58 +01:00
