Gregory
e3da8956c8
debug
2023-04-05 18:44:06 -07:00
becker33
adf5a46313
[@spackbot] updating style on behalf of becker33
2023-04-05 18:44:06 -07:00
Gregory
4514b7c737
debugging
2023-04-05 18:44:06 -07:00
Gregory
f1c831cf6e
ensure timestamps are different in tests
2023-04-05 18:44:06 -07:00
Gregory Becker
c20a4d6ad1
fix bug in recreating new exchange view; test
2023-04-05 18:44:05 -07:00
Gregory Becker
4fbb23b89e
fix relocation broken symlink, discovered in testing
2023-04-03 23:51:08 -07:00
Gregory Becker
7904d2f13a
improved way to find oldest file in dir
2023-04-03 23:51:08 -07:00
Gregory Becker
fec8a6dace
address review: refactor for clarity
2023-04-03 23:51:08 -07:00
Greg Becker
4bc30a40a3
Apply suggestions from code review
...
Co-authored-by: Todd Gamblin <tgamblin@llnl.gov>
2023-04-03 23:51:07 -07:00
Greg Becker
2fba1a58ef
Update lib/spack/spack/environment/environment.py
...
Co-authored-by: Todd Gamblin <tgamblin@llnl.gov>
2023-04-03 23:51:07 -07:00
becker33
11139a9e39
[@spackbot] updating style on behalf of becker33
2023-04-03 23:51:07 -07:00
Gregory Becker
8ce1d9c05a
test for not writing the same view multiple times
2023-04-03 23:51:06 -07:00
Gregory Becker
f4865334ae
avoid writing the same view multiple times in exchange mode
2023-04-03 23:51:06 -07:00
Gregory Becker
c39610e5a0
update test to match new behavior
2023-04-03 23:51:06 -07:00
Gregory Becker
3146dbee05
typo
2023-04-03 23:51:06 -07:00
becker33
e6c34d39ba
[@spackbot] updating style on behalf of becker33
2023-04-03 23:51:05 -07:00
Gregory Becker
9a1e9574aa
remove auto replace with [exchange, symlink]
2023-04-03 23:51:05 -07:00
Gregory Becker
b97107af54
increase coverage
2023-04-03 23:51:05 -07:00
Gregory Becker
b48dfe6589
style
2023-04-03 23:51:04 -07:00
Gregory Becker
b8e58e9bd8
tinker with error message
2023-04-03 23:51:04 -07:00
Gregory Becker
bd305d48a9
enable spack env view regenerate -f
2023-04-03 23:50:53 -07:00
Gregory Becker
ae3a5f3848
additional testing
2023-04-03 23:49:58 -07:00
Gregory Becker
24dad071d4
remove vestigial code
2023-04-03 23:49:57 -07:00
Gregory Becker
5fc3dd7a26
Revert "test"
...
This reverts commit 23e65646d5
.
2023-04-03 23:49:57 -07:00
Gregory Becker
14f0ad4dd3
indentation typo
2023-04-03 23:49:57 -07:00
Gregory Becker
e156679b5a
test
2023-04-03 23:49:57 -07:00
Gregory Becker
6f959badcb
refactor for review
2023-04-03 23:49:56 -07:00
Gregory Becker
6bad473e4e
ensure renameat2 checks only run when required
2023-04-03 23:49:56 -07:00
Gregory Becker
9baea936f2
fix CDLL failure on windows
2023-04-03 23:49:56 -07:00
Gregory Becker
a30b07dd36
address review comments
2023-04-03 23:49:56 -07:00
Gregory Becker
553a9036eb
typo
2023-04-03 23:49:55 -07:00
Gregory Becker
d9637751cb
flake
2023-04-03 23:49:55 -07:00
Gregory Becker
f6c895ce10
more robust switching between atomic update methods
2023-04-03 23:49:55 -07:00
Gregory
17381f0281
fixup
2023-04-03 23:49:55 -07:00
Gregory
0d4acde1bf
clean up code/address review
2023-04-03 23:49:54 -07:00
Gregory
d3000d540e
remove vestigial code
2023-04-03 23:49:54 -07:00
Gregory
9df9bfa4b7
attempt at fixing typing info
2023-04-03 23:49:54 -07:00
becker33
5af37b7059
[@spackbot] updating style on behalf of becker33
2023-04-03 23:49:54 -07:00
Gregory
d31efd67ff
flake
2023-04-03 23:49:53 -07:00
Gregory
db3ee62dc0
use renameat2 for atomic view updates.
2023-04-03 23:49:53 -07:00
Gregory Becker
5a23819165
style
2023-03-23 12:48:02 -07:00
Gregory Becker
9df3b57f1f
update broadcast test to test excludes as well
2023-03-23 11:24:47 -07:00
Gregory Becker
788ad561bd
fix excludes with bcast
2023-03-23 11:24:06 -07:00
becker33
c8c025215d
[@spackbot] updating style on behalf of becker33
2023-03-13 17:14:28 +00:00
Gregory Becker
1df6a3196a
matrix broadcast: more robust test
2023-02-23 15:47:11 -08:00
Gregory Becker
7014eb3236
matrices: broadcast key combinatorially applies to all nodes in matrix
2023-02-23 15:40:34 -08:00
Todd Gamblin
6b27aebeb4
colify.py: get rid of **kwargs ( #35641 )
...
`colify` is an old module in Spack that still uses `**kwargs` liberally.
We should be more explicit. Doing this eliminates the need for many
checks (can't pass the wrong arg if it isn't allowed) and makes the
function documentation more clear.
2023-02-23 11:18:54 -08:00
Harmen Stoppels
3d41b71664
buildcache push: ensure bool arguments for include_* ( #35632 )
...
Fixes a bug introduced in 44ed0de8c0
where the push method of binary_distribution now takes named args
include_root and include_depedencies, to avoid the **kwarg hole.
But the call site wasn't update and we passed a dict of keys/values instead
of arguments, which resulted in a call like this:
```
push(include_root={"include_root": True, "include_dependencies": False})
```
This commit fixes that, and adds a test to see if we push the correct packages.
2023-02-23 01:44:47 +01:00
Harmen Stoppels
3be9af8c13
copy_files_to_artifacts: error -> warning ( #35613 )
...
This error shows up a lot, typically it's harmless because an error
happened before the source build even started, in which case we don't
have build logs to copy. So, warn instead of error, cause it distracts
from the actual CI error.
2023-02-22 11:53:42 +00:00
Harmen Stoppels
6e477d547d
add cdash arg to source build only ( #35565 )
2023-02-22 11:08:32 +01:00