Merge branch 'develop' into woptim/extend-commit-fetch

This will fetch even if the commit is on a PR from a fork

lib/spack/spack/fetch_strategy.py

@@ -862,6 +862,9 @@ def clone(self, dest=None, commit=None, branch=None, tag=None, bare=False):
                 )
 
             with working_dir(dest):
+                # By defaults, on all references are fetched by the clone
+                fetch_args = ["fetch", "origin", commit]
+                git(*fetch_args)
                 checkout_args = ["checkout", commit]
                 if not debug:
                     checkout_args.insert(1, "--quiet")

lib/spack/spack/version.py

@@ -1336,6 +1336,10 @@ def lookup_ref(self, ref):
             # won't properly update the local rev-list)
             self.fetcher.git("fetch", "--tags", output=os.devnull, error=os.devnull)
 
+            # We need to do an attempt at fetching the commit in order to
+            # be sure to get it in case it comes from a PR in a fork.
+            self.fetcher.git("fetch", "origin", "%s" % ref, output=os.devnull, error=os.devnull)
+
             # Ensure ref is a commit object known to git
             # Note the brackets are literals, the ref replaces the format string
             try: