8e61f54260
This PR will add a new audit, specifically for spack package homepage urls (and eventually
other kinds I suspect) to see if there is an http address that can be changed to https.
Usage is as follows:
```bash
$ spack audit packages-https <package>
```
And in list view:
```bash
$ spack audit list
generic:
Generic checks relying on global variables
configs:
Sanity checks on compilers.yaml
Sanity checks on packages.yaml
packages:
Sanity checks on specs used in directives
packages-https:
Sanity checks on https checks of package urls, etc.
```
I think it would be unwise to include with packages, because when run for all, since we do requests it takes a long time. I also like the idea of more well scoped checks - likely there will be other addresses for http/https within a package that we eventually check. For now, there are two error cases - one is when an https url is tried but there is some SSL error (or other error that means we cannot update to https):
```bash
$ spack audit packages-https zoltan
PKG-HTTPS-DIRECTIVES: 1 issue found
1. Error with attempting https for "zoltan":
<urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: Hostname mismatch, certificate is not valid for 'www.cs.sandia.gov'. (_ssl.c:1125)>
```
This is either not fixable, or could be fixed with a change to the url or (better) contacting the site owners to ask about some certificate or similar.
The second case is when there is an http that needs to be https, which is a huge issue now, but hopefully not after this spack PR.
```bash
$ spack audit packages-https xman
Package "xman" uses http but has a valid https endpoint.
```
And then when a package is fixed:
```bash
$ spack audit packages-https zlib
PKG-HTTPS-DIRECTIVES: 0 issues found.
```
And that's mostly it. :)
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Co-authored-by: vsoch <vsoch@users.noreply.github.com>
63 lines
2.6 KiB
Python
63 lines
2.6 KiB
Python
# Copyright 2013-2021 Lawrence Livermore National Security, LLC and other
|
|
# Spack Project Developers. See the top-level COPYRIGHT file for details.
|
|
#
|
|
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
|
|
|
|
from spack import *
|
|
|
|
|
|
class Knem(AutotoolsPackage):
|
|
"""KNEM is a Linux kernel module enabling high-performance intra-node MPI
|
|
communication for large messages."""
|
|
|
|
homepage = "https://knem.gforge.inria.fr"
|
|
url = "https://gitlab.inria.fr/knem/knem/uploads/4a43e3eb860cda2bbd5bf5c7c04a24b6/knem-1.1.4.tar.gz"
|
|
list_url = "https://knem.gitlabpages.inria.fr/download"
|
|
git = "https://gitlab.inria.fr/knem/knem.git"
|
|
|
|
maintainers = ['skosukhin']
|
|
|
|
version('master', branch='master')
|
|
version('1.1.4', sha256='9f0e360579ae7655e07d6644583fd325515e9ff2b42ef5decb5421a003510937',
|
|
url="https://gitlab.inria.fr/knem/knem/uploads/4a43e3eb860cda2bbd5bf5c7c04a24b6/knem-1.1.4.tar.gz")
|
|
version('1.1.3', sha256='50d3c4a20c140108b8ce47aaafd0ade0927d6f507e1b5cc690dd6bddeef30f60',
|
|
url="https://gitlab.inria.fr/knem/knem/uploads/59375c38537e6ff2d94209f190c54aa6/knem-1.1.3.tar.gz")
|
|
|
|
variant('hwloc', default=True,
|
|
description='Enable hwloc in the user-space tools')
|
|
|
|
patch('https://gitlab.inria.fr/knem/knem/-/commit/5c8cb902d6040df58cdc4e4e4c10d1f1426c3525.patch',
|
|
sha256='78885a02d6f031a793db6a7190549f8d64c8606b353051d65f8e3f802b801902',
|
|
when='@1.1.4')
|
|
|
|
depends_on('hwloc', when='+hwloc')
|
|
depends_on('pkgconfig', type='build', when='+hwloc')
|
|
depends_on('autoconf', type='build', when='@master')
|
|
depends_on('automake', type='build', when='@master')
|
|
depends_on('m4', type='build', when='@master')
|
|
|
|
# The support for hwloc was added in 0.9.1:
|
|
conflicts('+hwloc', when='@:0.9.0')
|
|
|
|
# Ideally, we should list all non-Linux-based platforms here:
|
|
conflicts('platform=darwin')
|
|
|
|
# All compilers except for gcc are in conflict:
|
|
for __compiler in spack.compilers.supported_compilers():
|
|
if __compiler != 'gcc':
|
|
conflicts('%{0}'.format(__compiler),
|
|
msg='Linux kernel module must be compiled with gcc')
|
|
|
|
@run_before('build')
|
|
def override_kernel_compiler(self):
|
|
# Override the compiler for kernel module source files. We need
|
|
# this additional argument for all installation phases.
|
|
make.add_default_arg('CC={0}'.format(spack_cc))
|
|
|
|
def configure_args(self):
|
|
return self.enable_or_disable('hwloc')
|
|
|
|
@when('@master')
|
|
def autoreconf(self, spec, prefix):
|
|
Executable('./autogen.sh')()
|