spack/var/spack/repos/builtin/packages/py-mysqlclient/use-pkg-config.patch

--- a/setup_posix.py	2019-11-06 02:21:07.000000000 -0500
+++ b/setup_posix.py	2024-05-13 18:22:02.200012959 -0400
@@ -1,56 +1,31 @@
-import os, sys
+import os, subprocess, sys
 try:
     from ConfigParser import SafeConfigParser
 except ImportError:
     from configparser import ConfigParser as SafeConfigParser
 
-# This dequote() business is required for some older versions
-# of mysql_config
 
-def dequote(s):
-    if not s:
-        raise Exception("Wrong MySQL configuration: maybe https://bugs.mysql.com/bug.php?id=86971 ?")
-    if s[0] in "\"'" and s[0] == s[-1]:
-        s = s[1:-1]
-    return s
-
-_mysql_config_path = "mysql_config"
-
-def mysql_config(what):
-    from os import popen
-
-    f = popen("%s --%s" % (_mysql_config_path, what))
-    data = f.read().strip().split()
-    ret = f.close()
-    if ret:
-        if ret/256:
-            data = []
-        if ret/256 > 1:
-            raise EnvironmentError("%s not found" % (_mysql_config_path,))
-    return data
+def find_package_name():
+    """Get available pkg-config package name"""
+    packages = ["mysqlclient", "mariadb"]
+    for pkg in packages:
+        try:
+            cmd = f"pkg-config --exists {pkg}"
+            print(f"Trying {cmd}")
+            subprocess.check_call(cmd, shell=True)
+        except subprocess.CalledProcessError as err:
+            print(err)
+        else:
+            return pkg
+    raise Exception("Cannot find valid pkg-config")
+
 
 def get_config():
     from setup_common import get_metadata_and_options, enabled, create_release_file
-    global _mysql_config_path
 
     metadata, options = get_metadata_and_options()
 
-    if 'mysql_config' in options:
-        _mysql_config_path = options['mysql_config']
-    else:
-        try:
-            mysql_config('version')
-        except EnvironmentError:
-            # try mariadb_config
-            _mysql_config_path = "mariadb_config"
-            try:
-                mysql_config('version')
-            except EnvironmentError:
-                _mysql_config_path = "mysql_config"
-
-    extra_objects = []
     static = enabled(options, 'static')
-
     # allow a command-line option to override the base config file to permit
     # a static build to be created via requirements.txt
     #
@@ -58,65 +33,51 @@
         static = True
         sys.argv.remove('--static')
 
-    libs = mysql_config("libs")
-    library_dirs = [dequote(i[2:]) for i in libs if i.startswith('-L')]
-    libraries = [dequote(i[2:]) for i in libs if i.startswith('-l')]
-    extra_link_args = [x for x in libs if not x.startswith(('-l', '-L'))]
-
-    removable_compile_args = ('-I', '-L', '-l')
-    extra_compile_args = [i.replace("%", "%%") for i in mysql_config("cflags")
-                          if i[:2] not in removable_compile_args]
-
-    # Copy the arch flags for linking as well
-    for i in range(len(extra_compile_args)):
-        if extra_compile_args[i] == '-arch':
-            extra_link_args += ['-arch', extra_compile_args[i + 1]]
+    ldflags = os.environ.get("MYSQLCLIENT_LDFLAGS")
+    cflags = os.environ.get("MYSQLCLIENT_CFLAGS")
 
-    include_dirs = [dequote(i[2:])
-                    for i in mysql_config('include') if i.startswith('-I')]
-
-    if static:
-        # properly handle mysql client libraries that are not called libmysqlclient
-        client = None
-        CLIENT_LIST = ['mysqlclient', 'mysqlclient_r', 'mysqld', 'mariadb',
-                       'mariadbclient', 'perconaserverclient', 'perconaserverclient_r']
-        for c in CLIENT_LIST:
-            if c in libraries:
-                client = c
-                break
-
-        if client == 'mariadb':
-            client = 'mariadbclient'
-        if client is None:
-            raise ValueError("Couldn't identify mysql client library")
-
-        extra_objects.append(os.path.join(library_dirs[0], 'lib%s.a' % client))
-        if client in libraries:
-            libraries.remove(client)
+    pkg_name = None
+    static_opt = " --static" if static else ""
+    if not (cflags and ldflags):
+        pkg_name = find_package_name()
+    if not cflags:
+        cflags = subprocess.check_output(
+            f"pkg-config{static_opt} --cflags {pkg_name}", encoding="utf-8", shell=True
+        )
+    if not ldflags:
+        ldflags = subprocess.check_output(
+            f"pkg-config{static_opt} --libs {pkg_name}", encoding="utf-8", shell=True
+        )
+
+    cflags = cflags.split()
+    for f in cflags:
+        if f.startswith("-std="):
+            break
+    else:
+        cflags += ["-std=c99"]
 
-    name = "mysqlclient"
-    metadata['name'] = name
+    ldflags = ldflags.split()
 
     define_macros = [
         ('version_info', metadata['version_info']),
         ('__version__', metadata['version']),
         ]
-    create_release_file(metadata)
-    del metadata['version_info']
     ext_options = dict(
-        library_dirs = library_dirs,
-        libraries = libraries,
-        extra_compile_args = extra_compile_args,
-        extra_link_args = extra_link_args,
-        include_dirs = include_dirs,
-        extra_objects = extra_objects,
-        define_macros = define_macros,
+        extra_compile_args=cflags,
+        extra_link_args=ldflags,
+        define_macros=define_macros,
     )
-
     # newer versions of gcc require libstdc++ if doing a static build
     if static:
         ext_options['language'] = 'c++'
 
+    print("Options for building extention module:")
+    for k, v in ext_options.items():
+        print(f"  {k}: {v}")
+
+    create_release_file(metadata)
+    del metadata['version_info']
+        
     return metadata, ext_options
 
 if __name__ == "__main__":