Carson Woods
33752eabb8
Improve package source code context display on error ( #37655 )
...
Spack displays package code context when it shouldn't (e.g., on `FetchError`s)
and doesn't display it when it should (e.g., when errors occur in builder classes.
The line attribution can sometimes be off by one, as well.
- [x] Display package context when errors occur in a subclass of `PackageBase`
- [x] Display package context when errors occur in a subclass of `BaseBuilder`
- [x] Do not display package context when errors occur in `PackageBase`,
`BaseBuilder` or other core code that is not in a `package.py` file.
- [x] Fix off-by-one error for core code (don't subtract one from the line number *unless*
it's in an actual `package.py` file.
---------
Co-authored-by: Todd Gamblin <tgamblin@llnl.gov >
2023-05-15 13:38:11 -07:00
..
2023-05-05 09:51:53 +02:00
2023-05-10 15:31:07 +02:00
2023-05-15 13:54:52 +02:00
2023-05-12 10:58:08 -04:00
2023-05-11 10:33:51 +02:00
2023-05-10 18:12:58 -04:00
2023-05-14 13:36:03 +02:00
2023-05-02 10:28:27 +02:00
2023-05-11 12:00:07 +02:00
2023-05-10 17:26:22 +02:00
2023-03-01 23:19:20 -08:00
2023-05-10 11:34:54 +02:00
2023-05-12 15:22:42 -05:00
2023-05-15 09:15:49 -07:00
2023-05-14 13:36:03 +02:00
2023-05-10 18:07:56 -04:00
2023-01-18 14:30:17 -08:00
2023-03-08 13:00:53 +01:00
2023-05-10 11:34:54 +02:00
2023-05-12 10:27:42 -07:00
2023-05-15 13:38:11 -07:00
2023-05-10 11:34:54 +02:00
2023-03-31 08:32:56 +02:00
2023-01-18 14:30:17 -08:00
2023-02-16 23:06:12 -06:00
2023-05-12 15:22:42 -05:00
2023-03-05 07:58:05 -08:00
2023-05-05 22:04:41 -06:00
2023-05-04 08:00:38 -07:00
2023-05-05 22:04:41 -06:00
2023-05-12 11:55:13 +02:00
2023-01-18 14:30:17 -08:00
2023-05-08 10:12:26 -07:00
2023-03-05 07:58:05 -08:00
2023-01-18 14:30:17 -08:00
2023-01-18 14:30:17 -08:00
2023-05-05 22:04:41 -06:00
2023-05-09 12:17:16 +02:00
2023-01-18 14:30:17 -08:00
2023-01-18 14:30:17 -08:00
2023-01-18 14:30:17 -08:00
2023-05-10 11:34:54 +02:00
2023-05-10 11:34:54 +02:00
2023-05-11 23:13:36 -04:00
2023-05-04 08:00:38 -07:00
2023-04-14 10:59:12 +02:00
2023-01-18 14:30:17 -08:00
2023-05-15 13:38:11 -07:00
2023-05-05 22:04:41 -06:00
2023-01-18 14:30:17 -08:00
2023-05-10 11:34:54 +02:00
2023-05-12 10:27:42 -07:00
2023-01-18 14:30:17 -08:00
2023-01-18 14:30:17 -08:00
2023-03-08 13:00:53 +01:00
2023-03-08 13:00:53 +01:00
2023-03-28 00:33:35 -04:00
2023-05-03 05:34:14 -04:00
2023-05-11 10:34:39 +02:00
2023-05-10 11:34:54 +02:00
2023-01-18 14:30:17 -08:00
2023-04-03 11:19:18 +02:00
2023-01-18 14:30:17 -08:00
2023-05-05 22:04:41 -06:00
2023-05-15 09:15:49 -07:00
2023-03-31 11:46:47 -07:00
2023-03-31 08:32:56 +02:00
2023-01-18 14:30:17 -08:00
2023-01-18 14:30:17 -08:00
2023-03-01 11:03:12 +01:00
2023-01-18 14:30:17 -08:00
2023-05-12 10:27:42 -07:00
2023-01-18 14:30:17 -08:00
2023-01-18 14:30:17 -08:00
2023-03-08 13:00:53 +01:00
2023-05-10 11:34:54 +02:00
2023-05-05 22:04:41 -06:00