spack/share/spack/qa
Tom Scogland 18c2f1a57a
refactor: packages import spack.package explicitly (#30404)
Explicitly import package utilities in all packages, and corresponding fallout.

This includes:

* rename `spack.package` to `spack.package_base`
* rename `spack.pkgkit` to `spack.package`
* update all packages in builtin, builtin_mock and tutorials to include `from spack.package import *`
* update spack style
  * ensure packages include the import
  * automatically add the new import and remove any/all imports of `spack` and `spack.pkgkit`
    from packages when using `--fix`
  * add support for type-checking packages with mypy when SPACK_MYPY_CHECK_PACKAGES
    is set in the environment
* fix all type checking errors in packages in spack upstream
* update spack create to include the new imports
* update spack repo to inject the new import, injection persists to allow for a deprecation period

Original message below:
 
As requested @adamjstewart, update all packages to use pkgkit.  I ended up using isort to do this,
so repro is easy:

```console
$ isort -a 'from spack.pkgkit import *' --rm 'spack' ./var/spack/repos/builtin/packages/*/package.py
$ spack style --fix
```

There were several line spacing fixups caused either by space manipulation in isort or by packages
that haven't been touched since we added requirements, but there are no functional changes in here.

* [x] add config to isort to make sure this is maintained going forward
2022-05-28 12:55:44 -04:00
..
configuration Add Github Actions for Windows (#24504) 2022-03-17 09:01:01 -07:00
bashcov Use kcov from official Ubuntu 20.04 repository (#25385) 2021-08-19 14:03:10 -07:00
completion-test.sh Update copyright year to 2022 2022-01-14 22:50:21 -08:00
flake8_formatter.py refactor: packages import spack.package explicitly (#30404) 2022-05-28 12:55:44 -04:00
run-build-tests Update copyright year to 2022 2022-01-14 22:50:21 -08:00
run-shell-tests Update copyright year to 2022 2022-01-14 22:50:21 -08:00
run-style-tests Update copyright year to 2022 2022-01-14 22:50:21 -08:00
run-unit-tests Use the non-deprecated MetaPathFinder interface (#29745) 2022-04-07 15:58:20 -07:00
setup_spack.ps1 Add Github Actions for Windows (#24504) 2022-03-17 09:01:01 -07:00
setup-env-test.csh Update copyright year to 2022 2022-01-14 22:50:21 -08:00
setup-env-test.fish Update copyright year to 2022 2022-01-14 22:50:21 -08:00
setup-env-test.sh Add a new test to catch exit code failure (#29244) 2022-02-28 12:55:24 -08:00
setup.sh Update copyright year to 2022 2022-01-14 22:50:21 -08:00
test-env-cfg.sh Update copyright year to 2022 2022-01-14 22:50:21 -08:00
test-framework.sh Update copyright year to 2022 2022-01-14 22:50:21 -08:00
vcvarsall.ps1 Add Github Actions for Windows (#24504) 2022-03-17 09:01:01 -07:00
windows_test_setup.ps1 Windows Support: Testing Suite integration 2022-03-17 09:01:01 -07:00