18c2f1a57a
Explicitly import package utilities in all packages, and corresponding fallout.
This includes:
* rename `spack.package` to `spack.package_base`
* rename `spack.pkgkit` to `spack.package`
* update all packages in builtin, builtin_mock and tutorials to include `from spack.package import *`
* update spack style
* ensure packages include the import
* automatically add the new import and remove any/all imports of `spack` and `spack.pkgkit`
from packages when using `--fix`
* add support for type-checking packages with mypy when SPACK_MYPY_CHECK_PACKAGES
is set in the environment
* fix all type checking errors in packages in spack upstream
* update spack create to include the new imports
* update spack repo to inject the new import, injection persists to allow for a deprecation period
Original message below:
As requested @adamjstewart, update all packages to use pkgkit. I ended up using isort to do this,
so repro is easy:
```console
$ isort -a 'from spack.pkgkit import *' --rm 'spack' ./var/spack/repos/builtin/packages/*/package.py
$ spack style --fix
```
There were several line spacing fixups caused either by space manipulation in isort or by packages
that haven't been touched since we added requirements, but there are no functional changes in here.
* [x] add config to isort to make sure this is maintained going forward
309 lines
13 KiB
Python
309 lines
13 KiB
Python
# Copyright 2013-2022 Lawrence Livermore National Security, LLC and other
|
|
# Spack Project Developers. See the top-level COPYRIGHT file for details.
|
|
#
|
|
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
|
|
|
|
|
|
import os
|
|
import socket
|
|
import sys
|
|
from os import environ as env
|
|
|
|
import llnl.util.tty as tty
|
|
|
|
from spack.package import *
|
|
|
|
|
|
def cmake_cache_entry(name, value, vtype=None):
|
|
"""
|
|
Helper that creates CMake cache entry strings used in
|
|
'host-config' files.
|
|
"""
|
|
if vtype is None:
|
|
if value == "ON" or value == "OFF":
|
|
vtype = "BOOL"
|
|
else:
|
|
vtype = "PATH"
|
|
return 'set({0} "{1}" CACHE {2} "")\n\n'.format(name, value, vtype)
|
|
|
|
|
|
class VtkH(Package, CudaPackage):
|
|
"""VTK-h is a toolkit of scientific visualization algorithms for emerging
|
|
processor architectures. VTK-h brings together several projects like VTK-m
|
|
and DIY2 to provide a toolkit with hybrid parallel capabilities."""
|
|
|
|
homepage = "https://github.com/Alpine-DAV/vtk-h"
|
|
url = "https://github.com/Alpine-DAV/vtk-h/releases/download/v0.5.8/vtkh-v0.5.8.tar.gz"
|
|
git = "https://github.com/Alpine-DAV/vtk-h.git"
|
|
|
|
maintainers = ['cyrush']
|
|
|
|
version('develop', branch='develop', submodules=True)
|
|
version('0.8.1', sha256="0cb1c84087e2b9385477fba3e7e197d6eabe1d366bd3bc87d7824e50dcdbe057")
|
|
version('0.8.0', sha256="8366ebfe094c258555f343ba1f9bbad1d8e4804f844768b639f6ff13a6390f29")
|
|
version('0.7.1', sha256="f28f7e6fb0f854a2293265b67cbdfb350b42c13ac08ffffe9cd246f3fe9fb77a")
|
|
version('0.7.0', sha256="1b3c15c1340c5f66edcc2962ffe2f0d86e155f45a4932cf9c407261c203fbc19")
|
|
version('0.6.9', sha256="8111f59c3528f02cb3c5083c17a1737dff9472266b156732794612471f3393c7")
|
|
version('0.6.8', sha256="0a37468ca65fdc12509b9fd53c74d5afb090630280e1161415d7377cad7d45f1")
|
|
version('0.6.7', sha256="aff3ab94cf137fbc3019149363d5d8a39d052b02ecef42c6bf6d076e538af3f2")
|
|
version('0.6.6', sha256="5fe8bae5f55dbeb3047a37499cc41f3b548e4d86f0058993069f1df57f7915a1")
|
|
version('0.6.5', sha256="3e566ee06150edece8a61711d9347de216c1ae45f3b4585784b2252ee9ff2a9b")
|
|
version('0.6.4', sha256="c1345679fa4110cba449a9e27d40774d53c1f0bbddd41e52f5eb395cec1ee2d0")
|
|
version('0.6.3', sha256="388ad05110efac45df6ae0d565a7d16bd05ff83c95b8b2b8daa206360ab73eec")
|
|
version('0.6.2', sha256="1623e943a5a034d474c04755be8f0f40b639183cd9b576b1289eeee687d4cf6d")
|
|
version('0.6.1', sha256="ca30b5ff1a48fa247cd20b3f19452f7744eb744465e0b64205135aece42d274f")
|
|
version('0.6.0', sha256="2fc054f88ae253fb1bfcae22a156bcced08eca963ba90384dcd5b5791e6dfbf4")
|
|
version('0.5.8', sha256="203b337f4280a24a2b75722384f77e0e2f5965058b541efc153db76b7ab98133")
|
|
version('0.5.7', sha256="e8c1925dc34ee6be17cec734121e43002e3c02b54ef8dac341b51a455b95e402")
|
|
version('0.5.6', sha256="c78c0fa71a9687c2951a06d2112b52aa81fdcdcfbc9464d1578326d03fbb205e")
|
|
version('0.5.4', sha256="92bf3741df7a15e36ff41a9a783f3b88eecc86e55cad1defba76f141baa2610b")
|
|
version('0.5.3', sha256="0c4aae3bd2a5906738a6806de2b62ea2049ac8b40ebe7fc2ba25505272c2d359")
|
|
version('0.5.2', sha256="db2e6250c0ece6381fc90540317ad7b5869dbcce0231ce9be125916a77bfdb25")
|
|
|
|
variant("shared", default=True, description="Build vtk-h as shared libs")
|
|
variant("mpi", default=True, description="build mpi support")
|
|
variant("serial", default=True, description="build serial (non-mpi) libraries")
|
|
variant("openmp", default=(sys.platform != 'darwin'),
|
|
description="build openmp support")
|
|
variant("logging", default=False, description="Build vtk-h with logging enabled")
|
|
variant("contourtree", default=False, description="Enable contour tree support")
|
|
|
|
# Certain CMake versions have been found to break for our use cases
|
|
depends_on("cmake@3.14.1:3.14,3.18.2:", type='build')
|
|
|
|
depends_on("mpi", when="+mpi")
|
|
|
|
depends_on("vtk-m~tbb")
|
|
depends_on("vtk-m@:1.6", when="@:0.7")
|
|
depends_on("vtk-m@1.7:", when="@0.8:")
|
|
|
|
depends_on("vtk-m+openmp", when="+openmp")
|
|
depends_on("vtk-m~openmp", when="~openmp")
|
|
|
|
depends_on("vtk-m~cuda", when="~cuda")
|
|
depends_on("vtk-m+cuda", when="+cuda")
|
|
for _arch in CudaPackage.cuda_arch_values:
|
|
depends_on("vtk-m cuda_arch={0}".format(_arch), when="+cuda cuda_arch={0}".format(_arch))
|
|
|
|
depends_on("vtk-m+shared", when="+shared")
|
|
depends_on("vtk-m~shared", when="~shared")
|
|
|
|
patch('vtk-h-shared-cuda.patch', when='@0.8.0,0.8.1 +cuda')
|
|
|
|
def install(self, spec, prefix):
|
|
with working_dir('spack-build', create=True):
|
|
cmake_args = ["../src",
|
|
"-DVTKM_DIR={0}".format(spec["vtk-m"].prefix),
|
|
"-DENABLE_TESTS=OFF",
|
|
"-DBUILD_TESTING=OFF"]
|
|
|
|
# shared vs static libs logic
|
|
# force static when building with CUDA <= 1.6
|
|
if "+cuda" in spec and spec["vtk-m"].satisfies('@:1.6'):
|
|
cmake_args.append('-DBUILD_SHARED_LIBS=OFF')
|
|
else:
|
|
if "+shared" in spec:
|
|
cmake_args.append('-DBUILD_SHARED_LIBS=ON')
|
|
else:
|
|
cmake_args.append('-DBUILD_SHARED_LIBS=OFF')
|
|
|
|
# mpi support
|
|
if "+mpi" in spec:
|
|
mpicc = spec['mpi'].mpicc
|
|
mpicxx = spec['mpi'].mpicxx
|
|
cmake_args.extend(["-DMPI_C_COMPILER={0}".format(mpicc),
|
|
"-DMPI_CXX_COMPILER={0}".format(mpicxx)])
|
|
mpiexe_bin = join_path(spec['mpi'].prefix.bin, 'mpiexec')
|
|
if os.path.isfile(mpiexe_bin):
|
|
cmake_args.append("-DMPIEXEC={0}".format(mpiexe_bin))
|
|
|
|
# openmp support
|
|
if "+openmp" in spec:
|
|
cmake_args.append("-DENABLE_OPENMP=ON")
|
|
|
|
# build with logging
|
|
if "+logging" in spec:
|
|
cmake_args.append("-DENABLE_LOGGING=ON")
|
|
|
|
if "+contourtree" in spec:
|
|
cmake_args.append("-DENABLE_FILTER_CONTOUR_TREE=ON")
|
|
|
|
# cuda support
|
|
if "+cuda" in spec:
|
|
cmake_args.append("-DVTKm_ENABLE_CUDA:BOOL=ON")
|
|
cmake_args.append("-DENABLE_CUDA:BOOL=ON")
|
|
cmake_args.append("-DCMAKE_CUDA_HOST_COMPILER={0}".format(
|
|
env["SPACK_CXX"]))
|
|
else:
|
|
cmake_args.append("-DVTKm_ENABLE_CUDA:BOOL=OFF")
|
|
cmake_args.append("-DENABLE_CUDA:BOOL=OFF")
|
|
# use release, instead of release with debug symbols b/c vtkh libs
|
|
# can overwhelm compilers with too many symbols
|
|
for arg in std_cmake_args:
|
|
if arg.count("CMAKE_BUILD_TYPE") == 0:
|
|
cmake_args.extend(std_cmake_args)
|
|
cmake_args.append("-DCMAKE_BUILD_TYPE=Release")
|
|
cmake(*cmake_args)
|
|
make()
|
|
make("install")
|
|
|
|
host_cfg_fname = self.create_host_config(spec,
|
|
prefix)
|
|
|
|
install(host_cfg_fname, prefix)
|
|
|
|
def create_host_config(self, spec, prefix, py_site_pkgs_dir=None):
|
|
"""
|
|
This method creates a 'host-config' file that specifies
|
|
all of the options used to configure and build vtkh.
|
|
"""
|
|
|
|
#######################
|
|
# Compiler Info
|
|
#######################
|
|
c_compiler = env["SPACK_CC"]
|
|
cpp_compiler = env["SPACK_CXX"]
|
|
|
|
#######################################################################
|
|
# By directly fetching the names of the actual compilers we appear
|
|
# to doing something evil here, but this is necessary to create a
|
|
# 'host config' file that works outside of the spack install env.
|
|
#######################################################################
|
|
|
|
sys_type = spec.architecture
|
|
# if on llnl systems, we can use the SYS_TYPE
|
|
if "SYS_TYPE" in env:
|
|
sys_type = env["SYS_TYPE"]
|
|
|
|
##############################################
|
|
# Find and record what CMake is used
|
|
##############################################
|
|
|
|
cmake_exe = spec['cmake'].command.path
|
|
|
|
host_cfg_fname = "%s-%s-%s-vtkh.cmake" % (socket.gethostname(),
|
|
sys_type,
|
|
spec.compiler)
|
|
|
|
cfg = open(host_cfg_fname, "w")
|
|
cfg.write("##################################\n")
|
|
cfg.write("# spack generated host-config\n")
|
|
cfg.write("##################################\n")
|
|
cfg.write("# {0}-{1}\n".format(sys_type, spec.compiler))
|
|
cfg.write("##################################\n\n")
|
|
|
|
# Include path to cmake for reference
|
|
cfg.write("# cmake from spack \n")
|
|
cfg.write("# cmake executable path: %s\n\n" % cmake_exe)
|
|
|
|
#######################
|
|
# Compiler Settings
|
|
#######################
|
|
|
|
cfg.write("#######\n")
|
|
cfg.write("# using %s compiler spec\n" % spec.compiler)
|
|
cfg.write("#######\n\n")
|
|
cfg.write("# c compiler used by spack\n")
|
|
cfg.write(cmake_cache_entry("CMAKE_C_COMPILER", c_compiler))
|
|
cfg.write("# cpp compiler used by spack\n")
|
|
cfg.write(cmake_cache_entry("CMAKE_CXX_COMPILER", cpp_compiler))
|
|
|
|
# shared vs static libs
|
|
if "+shared" in spec:
|
|
cfg.write(cmake_cache_entry("BUILD_SHARED_LIBS", "ON"))
|
|
else:
|
|
cfg.write(cmake_cache_entry("BUILD_SHARED_LIBS", "OFF"))
|
|
|
|
#######################################################################
|
|
# Core Dependencies
|
|
#######################################################################
|
|
|
|
#######################
|
|
# VTK-h (and deps)
|
|
#######################
|
|
|
|
cfg.write("# vtk-m support \n")
|
|
|
|
if "+openmp" in spec:
|
|
cfg.write("# enable openmp support\n")
|
|
cfg.write(cmake_cache_entry("ENABLE_OPENMP", "ON"))
|
|
|
|
cfg.write("# vtk-m from spack\n")
|
|
cfg.write(cmake_cache_entry("VTKM_DIR", spec['vtk-m'].prefix))
|
|
|
|
#######################################################################
|
|
# Optional Dependencies
|
|
#######################################################################
|
|
|
|
#######################
|
|
# Serial
|
|
#######################
|
|
|
|
if "+serial" in spec:
|
|
cfg.write(cmake_cache_entry("ENABLE_SERIAL", "ON"))
|
|
else:
|
|
cfg.write(cmake_cache_entry("ENABLE_SERIAL", "OFF"))
|
|
|
|
#######################
|
|
# Logging
|
|
#######################
|
|
if "+logging" in spec:
|
|
cfg.write(cmake_cache_entry("ENABLE_LOGGING", "ON"))
|
|
else:
|
|
cfg.write(cmake_cache_entry("ENABLE_LOGGING", "OFF"))
|
|
|
|
#######################
|
|
# MPI
|
|
#######################
|
|
|
|
cfg.write("# MPI Support\n")
|
|
|
|
if "+mpi" in spec:
|
|
mpicc_path = spec['mpi'].mpicc
|
|
mpicxx_path = spec['mpi'].mpicxx
|
|
mpifc_path = spec['mpi'].mpifc
|
|
# if we are using compiler wrappers on cray systems
|
|
# use those for mpi wrappers, b/c spec['mpi'].mpicxx
|
|
# etc make return the spack compiler wrappers
|
|
# which can trip up mpi detection in CMake 3.14
|
|
if cpp_compiler == "CC":
|
|
mpicc_path = "cc"
|
|
mpicxx_path = "CC"
|
|
mpifc_path = "ftn"
|
|
cfg.write(cmake_cache_entry("ENABLE_MPI", "ON"))
|
|
cfg.write(cmake_cache_entry("MPI_C_COMPILER", mpicc_path))
|
|
cfg.write(cmake_cache_entry("MPI_CXX_COMPILER", mpicxx_path))
|
|
cfg.write(cmake_cache_entry("MPI_Fortran_COMPILER", mpifc_path))
|
|
mpiexe_bin = join_path(spec['mpi'].prefix.bin, 'mpiexec')
|
|
if os.path.isfile(mpiexe_bin):
|
|
# starting with cmake 3.10, FindMPI expects MPIEXEC_EXECUTABLE
|
|
# vs the older versions which expect MPIEXEC
|
|
if self.spec["cmake"].satisfies('@3.10:'):
|
|
cfg.write(cmake_cache_entry("MPIEXEC_EXECUTABLE",
|
|
mpiexe_bin))
|
|
else:
|
|
cfg.write(cmake_cache_entry("MPIEXEC",
|
|
mpiexe_bin))
|
|
else:
|
|
cfg.write(cmake_cache_entry("ENABLE_MPI", "OFF"))
|
|
|
|
#######################
|
|
# CUDA
|
|
#######################
|
|
|
|
cfg.write("# CUDA Support\n")
|
|
|
|
if "+cuda" in spec:
|
|
cfg.write(cmake_cache_entry("ENABLE_CUDA", "ON"))
|
|
else:
|
|
cfg.write(cmake_cache_entry("ENABLE_CUDA", "OFF"))
|
|
|
|
cfg.write("##################################\n")
|
|
cfg.write("# end spack generated host-config\n")
|
|
cfg.write("##################################\n")
|
|
cfg.close()
|
|
|
|
host_cfg_fname = os.path.abspath(host_cfg_fname)
|
|
tty.info("spack generated conduit host-config file: " + host_cfg_fname)
|
|
return host_cfg_fname
|