18c2f1a57a
Explicitly import package utilities in all packages, and corresponding fallout.
This includes:
* rename `spack.package` to `spack.package_base`
* rename `spack.pkgkit` to `spack.package`
* update all packages in builtin, builtin_mock and tutorials to include `from spack.package import *`
* update spack style
* ensure packages include the import
* automatically add the new import and remove any/all imports of `spack` and `spack.pkgkit`
from packages when using `--fix`
* add support for type-checking packages with mypy when SPACK_MYPY_CHECK_PACKAGES
is set in the environment
* fix all type checking errors in packages in spack upstream
* update spack create to include the new imports
* update spack repo to inject the new import, injection persists to allow for a deprecation period
Original message below:
As requested @adamjstewart, update all packages to use pkgkit. I ended up using isort to do this,
so repro is easy:
```console
$ isort -a 'from spack.pkgkit import *' --rm 'spack' ./var/spack/repos/builtin/packages/*/package.py
$ spack style --fix
```
There were several line spacing fixups caused either by space manipulation in isort or by packages
that haven't been touched since we added requirements, but there are no functional changes in here.
* [x] add config to isort to make sure this is maintained going forward
119 lines
4.5 KiB
Python
119 lines
4.5 KiB
Python
# Copyright 2013-2022 Lawrence Livermore National Security, LLC and other
|
|
# Spack Project Developers. See the top-level COPYRIGHT file for details.
|
|
#
|
|
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
|
|
|
|
import os
|
|
|
|
from spack.package import *
|
|
|
|
|
|
class Open3d(CMakePackage, CudaPackage):
|
|
"""Open3D: A Modern Library for 3D Data Processing."""
|
|
|
|
homepage = "http://www.open3d.org/"
|
|
url = "https://github.com/isl-org/Open3D/archive/refs/tags/v0.13.0.tar.gz"
|
|
git = "https://github.com/isl-org/Open3D.git"
|
|
|
|
version('0.13.0', tag='v0.13.0', submodules=True)
|
|
|
|
variant('python', default=False, description='Build the Python module')
|
|
|
|
# http://www.open3d.org/docs/latest/compilation.html
|
|
|
|
depends_on('cmake@3.19:', type='build')
|
|
# https://github.com/isl-org/Open3D/issues/3762
|
|
# https://github.com/isl-org/Open3D/issues/4570
|
|
depends_on('llvm@7:+clang+libcxx')
|
|
depends_on('eigen')
|
|
depends_on('flann')
|
|
# depends_on('fmt')
|
|
depends_on('glew')
|
|
depends_on('glfw')
|
|
# depends_on('imgui')
|
|
depends_on('jpeg')
|
|
# depends_on('liblzf')
|
|
depends_on('libpng')
|
|
depends_on('py-pybind11')
|
|
depends_on('qhull')
|
|
# depends_on('tinygltf')
|
|
# depends_on('tinyobjloader')
|
|
|
|
extends('python', when='+python', type=('build', 'link', 'run'))
|
|
depends_on('python@3.6:', when='+python', type=('build', 'link', 'run'))
|
|
depends_on('py-pip', when='+python', type='build')
|
|
depends_on('py-setuptools@40.8:', when='+python', type='build')
|
|
depends_on('py-wheel@0.36:', when='+python', type='build')
|
|
depends_on('py-numpy@1.18:', when='+python', type=('build', 'run'))
|
|
depends_on('py-pytest', when='+python', type='test')
|
|
depends_on('cuda@10.1:', when='+cuda')
|
|
|
|
# C++14 compiler required
|
|
conflicts('%gcc@:4')
|
|
conflicts('%clang@:6')
|
|
|
|
def patch(self):
|
|
# Force Python libraries to be installed to self.prefix
|
|
filter_file('pip install', 'pip install --prefix ' + self.prefix,
|
|
os.path.join('cpp', 'pybind', 'make_install_pip_package.cmake'))
|
|
|
|
def cmake_args(self):
|
|
args = [
|
|
self.define('BUILD_UNIT_TESTS', self.run_tests),
|
|
self.define_from_variant('BUILD_PYTHON_MODULE', 'python'),
|
|
self.define_from_variant('BUILD_CUDA_MODULE', 'cuda'),
|
|
# https://github.com/isl-org/Open3D/issues/4570
|
|
# self.define('BUILD_FILAMENT_FROM_SOURCE', 'ON'),
|
|
# Use Spack-installed dependencies instead of vendored dependencies
|
|
# Numerous issues with using externally installed dependencies:
|
|
# https://github.com/isl-org/Open3D/issues/4333
|
|
# https://github.com/isl-org/Open3D/issues/4360
|
|
self.define('USE_SYSTEM_EIGEN3', True),
|
|
self.define('USE_SYSTEM_FLANN', True),
|
|
# self.define('USE_SYSTEM_FMT', True),
|
|
self.define('USE_SYSTEM_GLEW', True),
|
|
self.define('USE_SYSTEM_GLFW', True),
|
|
# self.define('USE_SYSTEM_IMGUI', True),
|
|
self.define('USE_SYSTEM_JPEG', True),
|
|
# self.define('USE_SYSTEM_LIBLZF', True),
|
|
self.define('USE_SYSTEM_PNG', True),
|
|
self.define('USE_SYSTEM_PYBIND11', True),
|
|
self.define('USE_SYSTEM_QHULL', True),
|
|
# self.define('USE_SYSTEM_TINYGLTF', True),
|
|
# self.define('USE_SYSTEM_TINYOBJLOADER', True),
|
|
]
|
|
|
|
if '+python' in self.spec:
|
|
args.append(
|
|
self.define('PYTHON_EXECUTABLE', self.spec['python'].command.path))
|
|
|
|
return args
|
|
|
|
def check(self):
|
|
with working_dir(self.build_directory):
|
|
tests = Executable(os.path.join('bin', 'tests'))
|
|
tests()
|
|
|
|
def install(self, spec, prefix):
|
|
with working_dir(self.build_directory):
|
|
make('install')
|
|
if '+python' in spec:
|
|
make('install-pip-package')
|
|
|
|
# Tests don't pass unless all optional features are compiled, including PyTorch
|
|
# @run_after('install')
|
|
# @on_package_attributes(run_tests=True)
|
|
# def unit_test(self):
|
|
# if '+python' in self.spec:
|
|
# pytest = which('pytest')
|
|
# pytest(os.path.join('python', 'test'))
|
|
|
|
@run_after('install')
|
|
@on_package_attributes(run_tests=True)
|
|
def test(self):
|
|
if '+python' in self.spec:
|
|
self.run_test(self.spec['python'].command.path,
|
|
['-c', 'import open3d'],
|
|
purpose='checking import of open3d',
|
|
work_dir='spack-test')
|