71c77fa8fa
Since zsh can load bash completion files natively, seems reasonable to just turn this on. The only changes are to switch from `type -t` which zsh doesn't support to using `type` with a regex and adding a new arm to the sourcing of the completions to allow it to work for zsh as well as bash. Could use more bash/dash/etc testing probably, but everything I've thought to try has worked so far. Notes: * unit-test zsh support, fix issues Specifically fixed word splitting in completion-test, use a different method to apply sh emulation to zsh loaded bash completion, and fixed an incompatibility in regex operator quoting requirements. * compinit now ignores insecure directories Completion isn't meant to be enabled in non-interactive environments, so by default compinit will ask the user if they want to ignore insecure directories or load them anyway. To pass the spack unit tests in GH actions, this prompt must be disabled, so ignore explicitly until a better solution can be found. * debug functions test also requires bash emulation COMP_WORDS is a bash-ism that zsh doesn't natively support, turn on emulation for just that section of tests to allow the comparison to work. Does not change the behavior of the functions themselves since they are already pinned to sh emulation elsewhere. * propagate change to .in file * fix comment and update script based on .in
102 lines
2.9 KiB
Bash
Executable File
102 lines
2.9 KiB
Bash
Executable File
#!/bin/sh
|
|
#
|
|
# Copyright 2013-2020 Lawrence Livermore National Security, LLC and other
|
|
# Spack Project Developers. See the top-level COPYRIGHT file for details.
|
|
#
|
|
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
|
|
|
|
#
|
|
# This script tests that Spack's tab completion scripts work.
|
|
#
|
|
# The tests are portable to bash, zsh, and bourne shell, and can be run
|
|
# in any of these shells.
|
|
#
|
|
|
|
export QA_DIR=$(dirname "$0")
|
|
export SHARE_DIR=$(cd "$QA_DIR/.." && pwd)
|
|
export SPACK_ROOT=$(cd "$QA_DIR/../../.." && pwd)
|
|
|
|
. "$QA_DIR/test-framework.sh"
|
|
|
|
# Fail on undefined variables
|
|
set -u
|
|
|
|
# Source setup-env.sh before tests
|
|
. "$SHARE_DIR/setup-env.sh"
|
|
. "$SHARE_DIR/spack-completion.$_sp_shell"
|
|
|
|
title "Testing spack-completion.$_sp_shell with $_sp_shell"
|
|
|
|
# Spack command is now available
|
|
succeeds which spack
|
|
|
|
title 'Testing all subcommands'
|
|
# read line into an array portably
|
|
READ="read -ra line"
|
|
if [ -n "${ZSH_VERSION:-}" ]; then
|
|
READ=(read -rA line)
|
|
fi
|
|
while IFS=' ' $READ
|
|
do
|
|
# Test that completion with no args works
|
|
succeeds _spack_completions "${line[@]}" ''
|
|
|
|
# Test that completion with flags works
|
|
contains '-h --help' _spack_completions "${line[@]}" -
|
|
done <<- EOF
|
|
$(spack commands --aliases --format=subcommands)
|
|
EOF
|
|
|
|
title 'Testing for correct output'
|
|
contains 'compiler' _spack_completions spack ''
|
|
contains 'install' _spack_completions spack inst
|
|
contains 'find' _spack_completions spack help ''
|
|
contains 'hdf5' _spack_completions spack list ''
|
|
contains 'py-numpy' _spack_completions spack list py-
|
|
contains 'mpi' _spack_completions spack providers ''
|
|
contains 'builtin' _spack_completions spack repo remove ''
|
|
contains 'packages' _spack_completions spack config edit ''
|
|
contains 'python' _spack_completions spack extensions ''
|
|
contains 'hdf5' _spack_completions spack -d install --jobs 8 ''
|
|
contains 'hdf5' _spack_completions spack install -v ''
|
|
|
|
# XFAIL: Fails for Python 2.6 because pkg_resources not found?
|
|
#contains 'compilers.py' _spack_completions spack unit-test ''
|
|
|
|
_test_debug_functions() {
|
|
title 'Testing debugging functions'
|
|
|
|
if [ -n "${ZSH_VERSION:-}" ]; then
|
|
emulate -L sh
|
|
fi
|
|
|
|
# This is a particularly tricky case that involves the following situation:
|
|
# `spack -d [] install `
|
|
# Here, [] represents the cursor, which is in the middle of the line.
|
|
# We should tab-complete optional flags for `spack`, not optional flags for
|
|
# `spack install` or package names.
|
|
COMP_LINE='spack -d install '
|
|
COMP_POINT=9
|
|
COMP_WORDS=(spack -d install)
|
|
COMP_CWORD=2
|
|
COMP_KEY=9
|
|
COMP_TYPE=64
|
|
|
|
_bash_completion_spack
|
|
contains "--all-help" echo "${COMPREPLY[@]}"
|
|
|
|
contains "['spack', '-d', 'install', '']" _pretty_print COMP_WORDS[@]
|
|
|
|
# Set the rest of the intermediate variables manually
|
|
COMP_WORDS_NO_FLAGS=(spack install)
|
|
COMP_CWORD_NO_FLAGS=1
|
|
subfunction=_spack
|
|
cur=
|
|
|
|
list_options=true
|
|
contains "'True'" _test_vars
|
|
list_options=false
|
|
contains "'False'" _test_vars
|
|
}
|
|
_test_debug_functions
|