spack/lib/spack
Massimiliano Culpo 23e85f4086
Environments: unify the spec objects on first concretization (#29948)
Currently environments are indexed by build hashes. When looking into this bug I noticed there is a disconnect between environments that are concretized in memory for the first time and environments that are read from a `spack.lock`. The issue is that specs read from a `spack.lock` don't have a full hash, since they are indexed by a build hash which is strictly coarser. They are also marked "final" as they are read from a file, so we can't compute additional hashes. 

This bugfix PR makes "first concretization" equivalent to re-reading the specs from a corresponding `spack.lock`, and doing so unveiled a few tests were we were making wrong assumptions and relying on the fact that a `spack.lock` file was not there already.

* Add unit test
* Modify mpich to trigger jobs in pipelines
* Fix two failing unit tests
* Fix another full_hash vs. build_hash mismatch in tests
2022-04-08 15:26:17 -06:00
..
docs Deprecate top-level module config (#28659) 2022-04-08 19:00:35 +00:00
env Adding basic Windows features (#21259) 2022-03-17 09:01:01 -07:00
external Windows Support: Testing Suite integration 2022-03-17 09:01:01 -07:00
llnl Use the non-deprecated MetaPathFinder interface (#29745) 2022-04-07 15:58:20 -07:00
spack Environments: unify the spec objects on first concretization (#29948) 2022-04-08 15:26:17 -06:00