18c2f1a57a
Explicitly import package utilities in all packages, and corresponding fallout.
This includes:
* rename `spack.package` to `spack.package_base`
* rename `spack.pkgkit` to `spack.package`
* update all packages in builtin, builtin_mock and tutorials to include `from spack.package import *`
* update spack style
* ensure packages include the import
* automatically add the new import and remove any/all imports of `spack` and `spack.pkgkit`
from packages when using `--fix`
* add support for type-checking packages with mypy when SPACK_MYPY_CHECK_PACKAGES
is set in the environment
* fix all type checking errors in packages in spack upstream
* update spack create to include the new imports
* update spack repo to inject the new import, injection persists to allow for a deprecation period
Original message below:
As requested @adamjstewart, update all packages to use pkgkit. I ended up using isort to do this,
so repro is easy:
```console
$ isort -a 'from spack.pkgkit import *' --rm 'spack' ./var/spack/repos/builtin/packages/*/package.py
$ spack style --fix
```
There were several line spacing fixups caused either by space manipulation in isort or by packages
that haven't been touched since we added requirements, but there are no functional changes in here.
* [x] add config to isort to make sure this is maintained going forward
72 lines
2.6 KiB
Python
72 lines
2.6 KiB
Python
# Copyright 2013-2022 Lawrence Livermore National Security, LLC and other
|
|
# Spack Project Developers. See the top-level COPYRIGHT file for details.
|
|
#
|
|
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
|
|
|
|
from spack.package import *
|
|
|
|
|
|
class Cool(CMakePackage):
|
|
"""COOL provides specific software components and tools for the handling of the time
|
|
variation and versioning of the experiment conditions data."""
|
|
|
|
homepage = "https://coral-cool.docs.cern.ch/"
|
|
git = "https://gitlab.cern.ch/lcgcool/cool.git"
|
|
|
|
tags = ['hep']
|
|
maintainers = ['iarspider']
|
|
|
|
version('3.3.10', tag='COOL_3_3_10')
|
|
version('3.3.7', tag='COOL_3_3_7')
|
|
version('3.3.5', tag='COOL_3_3_5')
|
|
version('3.3.4', tag='COOL_3_3_4')
|
|
version('3.3.3', tag='COOL_3_3_3')
|
|
|
|
# Spack-specific patches:
|
|
# * Create python/PyCool/_internal directory
|
|
# (only necessary for Spack builds, for some reason)
|
|
# * Explicitly request Boost components
|
|
patch('cool.patch', level=0, when='@:3.3.8')
|
|
|
|
@when('@3.3.9:')
|
|
def patch(self):
|
|
filter_file("find_package(Boost REQUIRED)",
|
|
"find_package(Boost REQUIRED chrono system thread)",
|
|
"src/RelationalCool/CMakeLists.txt")
|
|
|
|
# BINARY_TAG is a combination of target, os, compiler name and build type (opt/dbg)
|
|
# If you override it, please also override it for CORAL
|
|
variant('binary_tag', default='auto',
|
|
description='Force specific BINARY_TAG, "auto" ' +
|
|
'will determine the correct value at buildtime')
|
|
|
|
depends_on('coral')
|
|
depends_on('root')
|
|
depends_on('vdt')
|
|
depends_on('xz')
|
|
depends_on('qt@5:', when='platform=linux')
|
|
depends_on('boost+chrono+system+thread')
|
|
depends_on('python')
|
|
|
|
def determine_binary_tag(self):
|
|
# As far as I can tell from reading the source code, `binary_tag`
|
|
# can be almost arbitrary. The only real difference it makes is
|
|
# disabling oracle dependency for non-x86 platforms.
|
|
if self.spec.variants['binary_tag'].value != 'auto':
|
|
return self.spec.variants['binary_tag'].value
|
|
|
|
binary_tag = str(self.spec.target.family) + \
|
|
'-' + self.spec.os + \
|
|
'-' + self.spec.compiler.name + str(self.spec.compiler.version.joined) + \
|
|
('-opt' if 'Rel' in self.spec.variants['build_type'].value else '-dbg')
|
|
|
|
return binary_tag
|
|
|
|
def cmake_args(self):
|
|
binary_tag = self.determine_binary_tag()
|
|
args = ['-DBINARY_TAG=' + binary_tag]
|
|
if self.spec['python'].version >= Version("3.0.0"):
|
|
args.append('-DLCG_python3=on')
|
|
|
|
return args
|