ff04d1bfc1
* Extract the MetaPathFinder and Loaders for packages in their own classes https://peps.python.org/pep-0451/ Currently, RepoPath and Repo implement the (deprecated) interface of MetaPathFinder (find_module) and of Loader (load_module). This commit extracts both of them and places the code in their own classes. The MetaPathFinder interface is updated to contain both the deprecated "find_module" (for Python 2.7 support) and the recommended "find_spec". Update of the Loader interface is deferred at a subsequent commit. * Move the lines to be prepended inside "RepoLoader" Also adjust the naming of a few variables too * Remove spack.util.imp, since code is only used in spack.repo * Remove support from loading Python modules Python > 3 but < 3.5 * Remove `Repo._create_namespace` This function was interacting badly with the MetaPathFinder and causing issues with "normal" imports. Removing the function allows to do things like: ```python import spack.pkg.builtin.mpich cls = spack.pkg.builtin.mpich.Mpich ``` * Remove code needed to trigger the Singleton evaluation The finder is coded in a way to trigger the Singleton, so we don't need external code now that we register it at module level into `sys.meta_path`. * Add unit tests
124 lines
4.1 KiB
Python
124 lines
4.1 KiB
Python
# Copyright 2013-2022 Lawrence Livermore National Security, LLC and other
|
|
# Spack Project Developers. See the top-level COPYRIGHT file for details.
|
|
#
|
|
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
|
|
|
|
import os
|
|
|
|
import pytest
|
|
|
|
import spack.package
|
|
import spack.paths
|
|
import spack.repo
|
|
|
|
|
|
@pytest.fixture()
|
|
def extra_repo(tmpdir_factory):
|
|
repo_namespace = 'extra_test_repo'
|
|
repo_dir = tmpdir_factory.mktemp(repo_namespace)
|
|
repo_dir.ensure('packages', dir=True)
|
|
|
|
with open(str(repo_dir.join('repo.yaml')), 'w') as f:
|
|
f.write("""
|
|
repo:
|
|
namespace: extra_test_repo
|
|
""")
|
|
return spack.repo.Repo(str(repo_dir))
|
|
|
|
|
|
def test_repo_getpkg(mutable_mock_repo):
|
|
mutable_mock_repo.get('a')
|
|
mutable_mock_repo.get('builtin.mock.a')
|
|
|
|
|
|
def test_repo_multi_getpkg(mutable_mock_repo, extra_repo):
|
|
mutable_mock_repo.put_first(extra_repo)
|
|
mutable_mock_repo.get('a')
|
|
mutable_mock_repo.get('builtin.mock.a')
|
|
|
|
|
|
def test_repo_multi_getpkgclass(mutable_mock_repo, extra_repo):
|
|
mutable_mock_repo.put_first(extra_repo)
|
|
mutable_mock_repo.get_pkg_class('a')
|
|
mutable_mock_repo.get_pkg_class('builtin.mock.a')
|
|
|
|
|
|
def test_repo_pkg_with_unknown_namespace(mutable_mock_repo):
|
|
with pytest.raises(spack.repo.UnknownNamespaceError):
|
|
mutable_mock_repo.get('unknown.a')
|
|
|
|
|
|
def test_repo_unknown_pkg(mutable_mock_repo):
|
|
with pytest.raises(spack.repo.UnknownPackageError):
|
|
mutable_mock_repo.get('builtin.mock.nonexistentpackage')
|
|
|
|
|
|
def test_repo_anonymous_pkg(mutable_mock_repo):
|
|
with pytest.raises(spack.repo.UnknownPackageError):
|
|
mutable_mock_repo.get('+variant')
|
|
|
|
|
|
@pytest.mark.maybeslow
|
|
def test_repo_last_mtime():
|
|
latest_mtime = max(os.path.getmtime(p.module.__file__)
|
|
for p in spack.repo.path.all_packages())
|
|
assert spack.repo.path.last_mtime() == latest_mtime
|
|
|
|
|
|
def test_repo_invisibles(mutable_mock_repo, extra_repo):
|
|
with open(os.path.join(extra_repo.root, 'packages', '.invisible'), 'w'):
|
|
pass
|
|
extra_repo.all_package_names()
|
|
|
|
|
|
@pytest.mark.parametrize('attr_name,exists', [
|
|
('cmake', True),
|
|
('__sphinx_mock__', False)
|
|
])
|
|
@pytest.mark.regression('20661')
|
|
def test_namespace_hasattr(attr_name, exists, mutable_mock_repo):
|
|
# Check that we don't fail on 'hasattr' checks because
|
|
# of a custom __getattr__ implementation
|
|
nms = spack.repo.SpackNamespace('spack.pkg.builtin.mock')
|
|
assert hasattr(nms, attr_name) == exists
|
|
|
|
|
|
@pytest.mark.regression('24552')
|
|
def test_all_package_names_is_cached_correctly():
|
|
assert 'mpi' in spack.repo.all_package_names(include_virtuals=True)
|
|
assert 'mpi' not in spack.repo.all_package_names(include_virtuals=False)
|
|
|
|
|
|
@pytest.mark.regression('29203')
|
|
def test_use_repositories_doesnt_change_class():
|
|
"""Test that we don't create the same package module and class multiple times
|
|
when swapping repositories.
|
|
"""
|
|
zlib_cls_outer = spack.repo.path.get_pkg_class('zlib')
|
|
current_paths = [r.root for r in spack.repo.path.repos]
|
|
with spack.repo.use_repositories(*current_paths):
|
|
zlib_cls_inner = spack.repo.path.get_pkg_class('zlib')
|
|
assert id(zlib_cls_inner) == id(zlib_cls_outer)
|
|
|
|
|
|
def test_import_repo_prefixes_as_python_modules(mock_packages):
|
|
import spack.pkg.builtin.mock
|
|
assert isinstance(spack.pkg, spack.repo.SpackNamespace)
|
|
assert isinstance(spack.pkg.builtin, spack.repo.SpackNamespace)
|
|
assert isinstance(spack.pkg.builtin.mock, spack.repo.SpackNamespace)
|
|
|
|
|
|
def test_absolute_import_spack_packages_as_python_modules(mock_packages):
|
|
import spack.pkg.builtin.mock.mpileaks
|
|
assert hasattr(spack.pkg.builtin.mock, 'mpileaks')
|
|
assert hasattr(spack.pkg.builtin.mock.mpileaks, 'Mpileaks')
|
|
assert isinstance(spack.pkg.builtin.mock.mpileaks.Mpileaks,
|
|
spack.package.PackageMeta)
|
|
assert issubclass(spack.pkg.builtin.mock.mpileaks.Mpileaks, spack.package.Package)
|
|
|
|
|
|
def test_relative_import_spack_packages_as_python_modules(mock_packages):
|
|
from spack.pkg.builtin.mock.mpileaks import Mpileaks
|
|
assert isinstance(Mpileaks, spack.package.PackageMeta)
|
|
assert issubclass(Mpileaks, spack.package.Package)
|