zhangyiss/the-littlest-jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/the-littlest-jupyterhub.git synced 2025-12-18 21:54:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Say 'running inside a docker container', not 'plain docker'

Browse Source 
'Plain docker' makes no sense
This commit is contained in:
yuvipanda
2019-05-20 09:52:50 -07:00
parent 0370b7513e
commit 1cb6717fea
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
bootstrap/bootstrap.py
View File

@@ -54,7 +54,8 @@ def validate_host():
print("Systemd is required to run TLJH") print("Systemd is required to run TLJH")
# Only fail running inside docker if systemd isn't present # Only fail running inside docker if systemd isn't present
if os.path.exists('/.dockerenv'): if os.path.exists('/.dockerenv'):
print("Running inside a plain docker container isn't supported") print("Running inside a docker container without systemd isn't supported")
print("We recommend against running a production TLJH instance inside a docker container")
print("For local development, see http://tljh.jupyter.org/en/latest/contributing/dev-setup.html") print("For local development, see http://tljh.jupyter.org/en/latest/contributing/dev-setup.html")
sys.exit(1) sys.exit(1)

5
integration-tests/test_bootstrap.py
View File

@@ -45,11 +45,12 @@ def test_ubuntu_too_old():
assert output.returncode == 1 assert output.returncode == 1
def test_inside_plain_docker(): def test_inside_no_systemd_docker():
output = run_bootstrap('plain-docker-test', 'ubuntu:18.04') output = run_bootstrap('plain-docker-test', 'ubuntu:18.04')
assert output.stdout.strip() == dedent(""" assert output.stdout.strip() == dedent("""
Systemd is required to run TLJH Systemd is required to run TLJH
Running inside a plain docker container isn't supported Running inside a docker container without systemd isn't supported
We recommend against running a production TLJH instance inside a docker container
For local development, see http://tljh.jupyter.org/en/latest/contributing/dev-setup.html For local development, see http://tljh.jupyter.org/en/latest/contributing/dev-setup.html
""").strip() """).strip()
assert output.returncode == 1 assert output.returncode == 1