From 3cdb9dfc8c036603f40f755790954a7ede3444cf Mon Sep 17 00:00:00 2001 From: huhuhang Date: Sat, 26 Jan 2019 10:03:50 +0800 Subject: [PATCH] fix GitHub login config missing callback URL --- docs/howto/auth/github.rst | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/howto/auth/github.rst b/docs/howto/auth/github.rst index d93cec8..f340c63 100644 --- a/docs/howto/auth/github.rst +++ b/docs/howto/auth/github.rst @@ -19,11 +19,11 @@ Step 1: Create a GitHub application #. Go to the `GitHub OAuth app creation page `_. * **Application name**: Choose a descriptive application name (e.g. ``tljh``) - * **Homepage URL**: Use the IP address or URL of your JupyterHub. e.g. ``http://```. + * **Homepage URL**: Use the IP address or URL of your JupyterHub. e.g. ``http(s)://```. * **Application description**: Use any description that you like. * **Authorization callback URL**: Insert text with the following form:: - http:///hub/oauth_callback + http(s):///hub/oauth_callback * When you're done filling in the page, it should look something like this: @@ -55,13 +55,16 @@ For more information on ``tljh-config``, see :ref:`topic/tljh-config`. .. image:: ../../images/notebook/new-terminal-button.png :alt: New terminal button. -#. Configure the GitHub OAuthenticator to use your client ID and secret with the following commands:: +#. Configure the GitHub OAuthenticator to use your client ID, client secret and callback URL with the following commands:: sudo tljh-config set auth.GitHubOAuthenticator.client_id '' :: sudo tljh-config set auth.GitHubOAuthenticator.client_secret '' + :: + + sudo tljh-config set auth.GitHubOAuthenticator.oauth_callback_url 'http(s):///hub/oauth_callback' #. Tell your JupyterHub to *use* the GitHub OAuthenticator for authentication::