zhangyiss/the-littlest-jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/the-littlest-jupyterhub.git synced 2025-12-18 21:54:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Set development env vars in dev documentation correctly

Browse Source 
Without this, the current dev setup documentation does not
work.
This commit is contained in:
YuviPanda
2024-12-08 19:23:21 -08:00
parent 0f7d4f4748
commit 53eceabd11
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
docs/contributing/dev-setup.md
View File

@@ -24,6 +24,9 @@ The easiest & safest way to develop & test TLJH is with [Docker](https://www.doc
--detach \ --detach \
--name=tljh-dev \ --name=tljh-dev \
--publish 12000:80 \ --publish 12000:80 \
--env TLJH_BOOTSTRAP_DEV=yes \
--env TLJH_BOOTSTRAP_PIP_SPEC=/srv/src \
--env PATH=/opt/tljh/hub/bin:${PATH} \
--mount type=bind,source="$(pwd)",target=/srv/src \ --mount type=bind,source="$(pwd)",target=/srv/src \
tljh-systemd tljh-systemd
``` ```

7
integration-tests/Dockerfile
View File

@@ -1,4 +1,4 @@
# Systemd inside a Docker container, for CI only # Systemd inside a Docker container, for CI and local development
ARG BASE_IMAGE=ubuntu:22.04 ARG BASE_IMAGE=ubuntu:22.04
FROM $BASE_IMAGE FROM $BASE_IMAGE
@@ -28,9 +28,4 @@ RUN systemctl set-default multi-user.target
STOPSIGNAL SIGRTMIN+3 STOPSIGNAL SIGRTMIN+3
# Uncomment these lines for a development install
# ENV TLJH_BOOTSTRAP_DEV=yes
# ENV TLJH_BOOTSTRAP_PIP_SPEC=/srv/src
# ENV PATH=/opt/tljh/hub/bin:${PATH}
CMD ["/bin/bash", "-c", "exec /lib/systemd/systemd --log-target=journal 3>&1"] CMD ["/bin/bash", "-c", "exec /lib/systemd/systemd --log-target=journal 3>&1"]