From 5a2ec9e517a77ad00cb1ad146d0a6fc700e24a8f Mon Sep 17 00:00:00 2001 From: yuvipanda Date: Sun, 12 Aug 2018 09:53:49 -0700 Subject: [PATCH] Don't fail silently when integration-test commands fail This will lead to tests reported as passing even when they are actually failing. --- .circleci/integration-test.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.circleci/integration-test.py b/.circleci/integration-test.py index fbd1272..93d0e2e 100755 --- a/.circleci/integration-test.py +++ b/.circleci/integration-test.py @@ -57,12 +57,7 @@ def run_container_command(container_name, cmd): 'docker', 'exec', '-it', container_name, '/bin/bash', '-c', cmd - ]) - - if proc.returncode != 0: - # Don't throw if command fails. This lets us continue next parts - # of tests. Not entirely sure this is the right thing to do though! - print(f'command {cmd} exited with return code {proc.returncode}') + ], check=True) def copy_to_container(container_name, src_path, dest_path):