zhangyiss/the-littlest-jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/the-littlest-jupyterhub.git synced 2025-12-18 21:54:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't fail silently when integration-test commands fail

Browse Source 
This will lead to tests reported as passing even when they are actually
failing.
This commit is contained in:
yuvipanda
2018-08-12 09:53:49 -07:00
parent 8b2980a20a
commit 5a2ec9e517
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
.circleci/integration-test.py
View File

@@ -57,12 +57,7 @@ def run_container_command(container_name, cmd):
'docker', 'exec', 'docker', 'exec',
'-it', container_name, '-it', container_name,
'/bin/bash', '-c', cmd '/bin/bash', '-c', cmd
]) ], check=True)
if proc.returncode != 0:
# Don't throw if command fails. This lets us continue next parts
# of tests. Not entirely sure this is the right thing to do though!
print(f'command {cmd} exited with return code {proc.returncode}')
def copy_to_container(container_name, src_path, dest_path): def copy_to_container(container_name, src_path, dest_path):