Add tljh-config remove-item to remove an item from a list

integration-tests/test_hub.py

@@ -36,9 +36,9 @@ async def test_user_code_execute():
 
 
 @pytest.mark.asyncio
-async def test_user_admin_code():
+async def test_user_admin_add():
     """
-    User logs in, starts a server & executes code
+    User is made an admin, logs in and we check if they are in admin group
     """
     # This *must* be localhost, not an IP
     # aiohttp throws away cookies if we are connecting to an IP!
@@ -56,11 +56,51 @@ async def test_user_admin_code():
     async with User(username, hub_url, partial(login_dummy, password='')) as u:
             await u.login()
             await u.ensure_server()
-            await u.start_kernel()
-            await u.assert_code_output("5 * 4", "20", 5, 5)
 
             # Assert that the user exists
             assert pwd.getpwnam(f'jupyter-{username}') is not None
 
             # Assert that the user has admin rights
+            assert f'jupyter-{username}' in grp.getgrnam('jupyterhub-admins').gr_mem
+
+
+@pytest.mark.asyncio
+async def test_user_admin_remove():
+    """
+    User is made an admin, logs in and we check if they are in admin group.
+
+    Then we remove them from admin group, and check they *aren't* in admin group :D
+    """
+    # This *must* be localhost, not an IP
+    # aiohttp throws away cookies if we are connecting to an IP!
+    hub_url = 'http://localhost'
+    username = secrets.token_hex(8)
+
+    tljh_config_path = [sys.executable, '-m', 'tljh.config']
+
+    assert 0 == await (await asyncio.create_subprocess_exec(*tljh_config_path, 'add-item', 'users.admin', username)).wait()
+    assert 0 == await (await asyncio.create_subprocess_exec(*tljh_config_path, 'reload')).wait()
+
+    # FIXME: wait for reload to finish & hub to come up
+    # Should be part of tljh-config reload
+    await asyncio.sleep(1)
+    async with User(username, hub_url, partial(login_dummy, password='')) as u:
+            await u.login()
+            await u.ensure_server()
+
+            # Assert that the user exists
+            assert pwd.getpwnam(f'jupyter-{username}') is not None
+
+            # Assert that the user has admin rights
+            assert f'jupyter-{username}' in grp.getgrnam('jupyterhub-admins').gr_mem
+
+
+            assert 0 == await (await asyncio.create_subprocess_exec(*tljh_config_path, 'remove-item', 'users.admin', username)).wait()
+            assert 0 == await (await asyncio.create_subprocess_exec(*tljh_config_path, 'reload')).wait()
+            await asyncio.sleep(1)
+
+            await u.stop_server()
+            await u.ensure_server()
+
+            # Assert that the user does *not* have admin rights
             assert f'jupyter-{username}' in grp.getgrnam('jupyterhub-admins').gr_mem