From 2ce091cbc5d1a961a90467eec35564c9bbc9e60e Mon Sep 17 00:00:00 2001 From: Erik Sundell Date: Mon, 1 Nov 2021 09:39:20 +0100 Subject: [PATCH] pre-commit: remove requirements-txt-fixer --- .pre-commit-config.yaml | 3 --- tljh/requirements-base.txt | 7 ++++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 206f842..a075ff9 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -40,9 +40,6 @@ repos: # Autoformat: Makes sure files end in a newline and only a newline. - id: end-of-file-fixer - # Autoformat: Sorts entries in requirements.txt. - - id: requirements-txt-fixer - # Lint: Check for files with names that would conflict on a # case-insensitive filesystem like MacOS HFS+ or Windows FAT. - id: check-case-conflict diff --git a/tljh/requirements-base.txt b/tljh/requirements-base.txt index 34e3d7a..02df904 100644 --- a/tljh/requirements-base.txt +++ b/tljh/requirements-base.txt @@ -1,9 +1,10 @@ # When tljh.installer runs, the users' environment as typically found in # /opt/tljh/user, is setup with these packages. # -# FIXME: a frozen version of this file should be used -# pinning only direct dependencies is a recipe for broken environments! - +# WARNING: The order of these dependencies matters, this was observed when using +# the requirements-txt-fixer pre-commit hook that sorted them and made +# our integration tests fail. +# # JupyterHub + notebook package are base requirements for user environment jupyterhub==1.* notebook==6.*