zhangyiss/the-littlest-jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/the-littlest-jupyterhub.git synced 2025-12-18 21:54:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't open file twice when downloading conda

Browse Source 
Unnecessary, and could also possibly cause races -
see https://github.com/jupyterhub/the-littlest-jupyterhub/pull/710#issuecomment-946165463
This commit is contained in:
YuviPanda
2021-10-19 14:05:36 +05:30
parent 4a7e545973
commit 9921403327
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tljh/conda.py
View File

@@ -49,9 +49,8 @@ def download_miniconda_installer(installer_url, sha256sum):
of given version, verifies the sha256sum & provides path to it to the `with` of given version, verifies the sha256sum & provides path to it to the `with`
block to run. block to run.
""" """
with tempfile.NamedTemporaryFile() as f: with tempfile.NamedTemporaryFile('wb') as f:
with open(f.name, 'wb') as f: f.write(requests.get(installer_url).content)
f.write(requests.get(installer_url).content)
if sha256_file(f.name) != sha256sum: if sha256_file(f.name) != sha256sum:
raise Exception('sha256sum hash mismatch! Downloaded file corrupted') raise Exception('sha256sum hash mismatch! Downloaded file corrupted')