zhangyiss/the-littlest-jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/the-littlest-jupyterhub.git synced 2025-12-18 21:54:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Min RK <benjaminrk@gmail.com>
This commit is contained in:
Erik Sundell
2021-10-22 15:32:45 +02:00
parent 5c8e5678ac
commit a32ec5ee04
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tljh/configurer.py
View File

@@ -161,7 +161,7 @@ def update_auth(c, config):
client_id: "..." client_id: "..."
client_secret: "..." client_secret: "..."
oauth_callback_url: "..." oauth_callback_url: "..."
ArbitraryKey: ClassName:
arbitrary_key: "..." arbitrary_key: "..."
arbitrary_key_with_none_value: arbitrary_key_with_none_value:
``` ```
@@ -185,13 +185,13 @@ def update_auth(c, config):
c.JupyterHub.authenticator_class = tljh_auth_config['type'] c.JupyterHub.authenticator_class = tljh_auth_config['type']
for auth_key, auth_value in tljh_auth_config.items(): for auth_key, auth_value in tljh_auth_config.items():
if auth_key == "type": if not (auth_key[0] == auth_key[0].upper() and isinstance(auth_value, dict)):
continue continue
traitlet_class_name = auth_key class_name = auth_key
traitlet_class_config = auth_value class_config_to_set = auth_value
traitlet_class_instance = getattr(c, traitlet_class_name) class_config = c[class_name]
for config_name, config_value in traitlet_class_config.items(): for config_name, config_value in class_config_to_set.items():
set_if_not_none(traitlet_class_instance, config_name, config_value) set_if_not_none(class_config, config_name, config_value)
def update_userlists(c, config): def update_userlists(c, config):