From c1aa30a479c6b03c70ae41c9848383560f1abbce Mon Sep 17 00:00:00 2001 From: Erik Sundell Date: Thu, 18 May 2023 23:49:39 +0200 Subject: [PATCH] hub env: remove pip pinning, always upgrade pip --- .github/workflows/unit-test.yaml | 3 --- bootstrap/bootstrap.py | 5 +---- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/unit-test.yaml b/.github/workflows/unit-test.yaml index 4dd1e4e..96b22bd 100644 --- a/.github/workflows/unit-test.yaml +++ b/.github/workflows/unit-test.yaml @@ -81,10 +81,7 @@ jobs: ${{ hashFiles('setup.py', 'dev-requirements.txt', '.github/workflows/unit-test.yaml') }} - name: Install Python dependencies - # Keep pip version pinning in sync with the one in bootstrap.py! - # See changelog at https://pip.pypa.io/en/latest/news/#changelog run: | - python3 -m pip install -U "pip==23.1.*" python3 -m pip install -r dev-requirements.txt python3 -m pip install -e . pip freeze diff --git a/bootstrap/bootstrap.py b/bootstrap/bootstrap.py index 9205f8f..46acf3f 100644 --- a/bootstrap/bootstrap.py +++ b/bootstrap/bootstrap.py @@ -475,11 +475,8 @@ def main(): os.makedirs(hub_env_prefix, exist_ok=True) run_subprocess(["python3", "-m", "venv", hub_env_prefix]) - # Upgrade pip - # Keep pip version pinning in sync with the one in unit-test.yml! - # See changelog at https://pip.pypa.io/en/latest/news/#changelog logger.info("Upgrading pip...") - run_subprocess([hub_env_pip, "install", "--upgrade", "pip==23.1.*"]) + run_subprocess([hub_env_pip, "install", "--upgrade", "pip"]) # Install/upgrade TLJH installer tljh_install_cmd = [hub_env_pip, "install", "--upgrade"]