zhangyiss/the-littlest-jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/the-littlest-jupyterhub.git synced 2025-12-18 21:54:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

hubtraf user login doesn't raise exceptions anymore

Browse Source
This commit is contained in:
GeorgianaElena
2020-07-21 16:58:54 +03:00
parent 3e62ee347a
commit c79df23873
1 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
integration-tests/test_admin_installer.py
View File

@@ -17,9 +17,9 @@ async def test_admin_login():
async with User(username, hub_url, partial(login_dummy, password=password)) as u: async with User(username, hub_url, partial(login_dummy, password=password)) as u:
await u.login() await u.login()
# If user is not logged in, this will raise an exception
await u.ensure_server_simulate() await u.ensure_server_simulate()
@pytest.mark.asyncio @pytest.mark.asyncio
@pytest.mark.parametrize( @pytest.mark.parametrize(
"username, password", "username, password",
@@ -35,11 +35,7 @@ async def test_unsuccessful_login(username, password):
""" """
hub_url = 'http://localhost' hub_url = 'http://localhost'
try:
async with User(username, hub_url, partial(login_dummy, password="")) as u: async with User(username, hub_url, partial(login_dummy, password="")) as u:
await u.login() user_logged_in = await u.login()
except Exception:
# This is what we except to happen assert user_logged_in == False
pass
else:
raise