zhangyiss/the-littlest-jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/the-littlest-jupyterhub.git synced 2025-12-18 21:54:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #869 from consideRatio/pr/remove-nteract

Browse Source 
breaking, maint: remove deprecated nteract-on-jupyter
This commit is contained in:
Yuvi Panda
2023-04-10 12:36:33 +05:30
committed by GitHub
parent 7fd97ad5e0 9e1bc61519
commit ff276d1a29
7 changed files with 4 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/contributing/docs.md
View File

@@ -150,7 +150,7 @@ documentation:
capitalized except when used in code / the commandline. capitalized except when used in code / the commandline.
- **Python** -- when referring to the language, capitalize Python. - **Python** -- when referring to the language, capitalize Python.
- **Notebook Interface** -- generic term for referring to JupyterLab, - **Notebook Interface** -- generic term for referring to JupyterLab,
nteract, classic notebook & other user interfaces for accessing classic notebook & other user interfaces for accessing.
## Guidelines for markdown files ## Guidelines for markdown files

2
docs/contributing/packages.md
View File

@@ -16,7 +16,7 @@ TLJH sets up two python environments during installation.
primarily since conda does not support ARM CPUs and we'd like to support the primarily since conda does not support ARM CPUs and we'd like to support the
RaspberryPI someday. Admins generally do not install custom packages RaspberryPI someday. Admins generally do not install custom packages
in this environment. in this environment.
2. **User Environment**. Jupyter Notebook, JupyterLab, nteract, kernels, 2. **User Environment**. Jupyter Notebook, JupyterLab, kernels,
and packages the users wanna use (such as numpy, scipy, etc) are installed and packages the users wanna use (such as numpy, scipy, etc) are installed
here. A [conda](https://conda.io) environment is used here, since here. A [conda](https://conda.io) environment is used here, since
a lot of scientific packages are available from Conda. `pip` is still a lot of scientific packages are available from Conda. `pip` is still

4
docs/topic/tljh-config.md
View File

@@ -138,8 +138,8 @@ sudo tljh-config reload proxy
### User Environment ### User Environment
`user_environment.default_app` Set default application users are `user_environment.default_app` Set default application users are launched into.
launched into. Currently this can only be set to: `jupyterlab` Currently this can only be set to: `classic` and `jupyterlab`.
```bash ```bash
sudo tljh-config set user_environment.default_app jupyterlab sudo tljh-config set user_environment.default_app jupyterlab

1
integration-tests/test_extensions.py
View File

@@ -14,7 +14,6 @@ def test_serverextensions():
extensions = [ extensions = [
"jupyterlab 3.", "jupyterlab 3.",
"nbgitpuller 1.", "nbgitpuller 1.",
"nteract_on_jupyter 2.1.",
"jupyter_resource_usage", "jupyter_resource_usage",
] ]

8
tests/test_configurer.py
View File

@@ -69,14 +69,6 @@ def test_app_jupyterlab():
assert c.Spawner.default_url == "/lab" assert c.Spawner.default_url == "/lab"
def test_app_nteract():
"""
Test setting nteract as default application
"""
c = apply_mock_config({"user_environment": {"default_app": "nteract"}})
assert c.Spawner.default_url == "/nteract"
def test_auth_default(): def test_auth_default():
""" """
Test default authentication settings with no overrides Test default authentication settings with no overrides

2
tljh/configurer.py
View File

@@ -228,8 +228,6 @@ def update_user_environment(c, config):
# Set default application users are launched into # Set default application users are launched into
if user_env["default_app"] == "jupyterlab": if user_env["default_app"] == "jupyterlab":
c.Spawner.default_url = "/lab" c.Spawner.default_url = "/lab"
elif user_env["default_app"] == "nteract":
c.Spawner.default_url = "/nteract"
def update_user_account_config(c, config): def update_user_account_config(c, config):

1
tljh/requirements-base.txt
View File

@@ -10,7 +10,6 @@ jupyterhub==3.*
notebook==6.* notebook==6.*
# Install additional notebook frontends! # Install additional notebook frontends!
jupyterlab==3.* jupyterlab==3.*
nteract-on-jupyter==2.*
# nbgitpuller for easily pulling in Git repositories # nbgitpuller for easily pulling in Git repositories
nbgitpuller==1.* nbgitpuller==1.*
# jupyter-resource-usage to show people how much RAM they are using # jupyter-resource-usage to show people how much RAM they are using