ci: add a patch to avoid nan comparison

This commit is contained in:
ToruNiina
2021-06-30 01:11:34 +09:00
parent 0aa3773860
commit 1d0b003312

View File

@@ -22,15 +22,40 @@ int main(int argc, char **argv)
if(data != serialized) if(data != serialized)
{ {
std::cerr << "============================================================\n"; // this is really a ditry hack, but is the easiest way...
std::cerr << "result (w/o comment) different: " << filename << std::endl; // TODO: cleanup by adding comparison function to check if a value is NaN or not
std::cerr << "------------------------------------------------------------\n"; if(filename.substr(filename.size() - 22, 22) == "float-inf-and-nan.toml" &&
std::cerr << "# serialized\n"; std::isnan (toml::find<double>(serialized, "nan")) &&
std::cerr << serialized; !std::signbit (toml::find<double>(serialized, "nan")) &&
std::cerr << "------------------------------------------------------------\n"; std::isnan (toml::find<double>(serialized, "nan_plus")) &&
std::cerr << "# data\n"; !std::signbit (toml::find<double>(serialized, "nan_plus")) &&
std::cerr << data; std::isnan (toml::find<double>(serialized, "nan_neg")) &&
return 1; std::signbit (toml::find<double>(serialized, "nan_neg")) &&
!std::isnan (toml::find<double>(serialized, "infinity")) &&
!std::isfinite(toml::find<double>(serialized, "infinity")) &&
!std::signbit (toml::find<double>(serialized, "infinity")) &&
!std::isnan (toml::find<double>(serialized, "infinity_plus")) &&
!std::isfinite(toml::find<double>(serialized, "infinity_plus")) &&
!std::signbit (toml::find<double>(serialized, "infinity_plus")) &&
!std::isnan (toml::find<double>(serialized, "infinity_neg")) &&
!std::isfinite(toml::find<double>(serialized, "infinity_neg")) &&
std::signbit (toml::find<double>(serialized, "infinity_neg")))
{
// then it is correctly serialized.
// Note that, the result of (nan == nan) is false. so `data == serialized` is false.
}
else
{
std::cerr << "============================================================\n";
std::cerr << "result (w/o comment) different: " << filename << std::endl;
std::cerr << "------------------------------------------------------------\n";
std::cerr << "# serialized\n";
std::cerr << serialized;
std::cerr << "------------------------------------------------------------\n";
std::cerr << "# data\n";
std::cerr << data;
return 1;
}
} }
} }
{ {
@@ -42,15 +67,46 @@ int main(int argc, char **argv)
const auto serialized = toml::parse<toml::preserve_comments>("tmp.toml"); const auto serialized = toml::parse<toml::preserve_comments>("tmp.toml");
if(data != serialized) if(data != serialized)
{ {
std::cerr << "============================================================\n"; // this is really a ditry hack, but is the easiest way...
std::cerr << "result (w/ comment) different: " << filename << std::endl; // TODO: cleanup by adding comparison function to check if a value is NaN or not
std::cerr << "------------------------------------------------------------\n"; if(filename.substr(filename.size() - 22, 22) == "float-inf-and-nan.toml" &&
std::cerr << "# serialized\n"; std::isnan (toml::find<double>(serialized, "nan")) &&
std::cerr << serialized; !std::signbit (toml::find<double>(serialized, "nan")) &&
std::cerr << "------------------------------------------------------------\n"; std::isnan (toml::find<double>(serialized, "nan_plus")) &&
std::cerr << "# data\n"; !std::signbit (toml::find<double>(serialized, "nan_plus")) &&
std::cerr << data; std::isnan (toml::find<double>(serialized, "nan_neg")) &&
return 1; std::signbit (toml::find<double>(serialized, "nan_neg")) &&
!std::isnan (toml::find<double>(serialized, "infinity")) &&
!std::isfinite(toml::find<double>(serialized, "infinity")) &&
!std::signbit (toml::find<double>(serialized, "infinity")) &&
!std::isnan (toml::find<double>(serialized, "infinity_plus")) &&
!std::isfinite(toml::find<double>(serialized, "infinity_plus")) &&
!std::signbit (toml::find<double>(serialized, "infinity_plus")) &&
!std::isnan (toml::find<double>(serialized, "infinity_neg")) &&
!std::isfinite(toml::find<double>(serialized, "infinity_neg")) &&
std::signbit (toml::find<double>(serialized, "infinity_neg")) &&
toml::find(data, "nan").comments() == toml::find(serialized, "nan").comments() &&
toml::find(data, "nan_plus").comments() == toml::find(serialized, "nan_plus").comments() &&
toml::find(data, "nan_neg").comments() == toml::find(serialized, "nan_neg").comments() &&
toml::find(data, "infinity").comments() == toml::find(serialized, "infinity").comments() &&
toml::find(data, "infinity_plus").comments() == toml::find(serialized, "infinity_plus").comments() &&
toml::find(data, "infinity_neg").comments() == toml::find(serialized, "infinity_neg").comments() )
{
// then it is correctly serialized.
// Note that, the result of (nan == nan) is false. so `data == serialized` is false.
}
else
{
std::cerr << "============================================================\n";
std::cerr << "result (w/ comment) different: " << filename << std::endl;
std::cerr << "------------------------------------------------------------\n";
std::cerr << "# serialized\n";
std::cerr << serialized;
std::cerr << "------------------------------------------------------------\n";
std::cerr << "# data\n";
std::cerr << data;
return 1;
}
} }
} }
return 0; return 0;